-
Notifications
You must be signed in to change notification settings - Fork 3
Expand file tree
/
Copy pathconfiguration_test.rb
More file actions
384 lines (304 loc) · 14 KB
/
configuration_test.rb
File metadata and controls
384 lines (304 loc) · 14 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
# typed: true
# frozen_string_literal: true
require "test_helper"
module LogStruct
class ConfigurationTest < ActiveSupport::TestCase
setup do
# Save original configuration
@original_config = LogStruct.config.dup
end
teardown do
# Restore original configuration
LogStruct.configuration = @original_config
end
def test_set_enabled_from_rails_env_with_matching_environment_in_ci
# Set up test conditions
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test]
# Stub Rails.env to match enabled_environments AND set CI=true
ClimateControl.modify CI: "true" do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LogStruct should be enabled in test environment when CI=true"
end
end
end
def test_set_enabled_from_rails_env_with_non_matching_environment
# Set up test conditions
LogStruct.config.enabled = true
LogStruct.config.enabled_environments = [:production]
# Stub Rails.env to not match enabled_environments
Rails.stub(:env, ActiveSupport::StringInquirer.new("development")) do
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled, "LogStruct should be disabled when environment doesn't match"
end
end
def test_set_enabled_from_rails_env_with_empty_environments_list
# Set up test conditions
LogStruct.config.enabled = true
LogStruct.config.enabled_environments = []
# Stub Rails.env with any environment since list is empty
Rails.stub(:env, ActiveSupport::StringInquirer.new("production")) do
# Empty list means no environments are enabled
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled, "LogStruct should be disabled with empty environments list"
end
end
def test_set_enabled_from_env_var_true
# Set up test conditions
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [] # No environments enabled
# Use ClimateControl to modify ENV
ClimateControl.modify LOGSTRUCT_ENABLED: "true" do
# Stub Rails.env to not match enabled_environments
Rails.stub(:env, ActiveSupport::StringInquirer.new("development")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LogStruct should be enabled when LOGSTRUCT_ENABLED=true"
end
end
end
def test_set_enabled_from_env_var_when_no
# Set up test conditions
LogStruct.config.enabled = true
LogStruct.config.enabled_environments = [] # No environments enabled
# Use ClimateControl to modify ENV
ClimateControl.modify LOGSTRUCT_ENABLED: "no" do
# Stub Rails.env to not match enabled_environments
Rails.stub(:env, ActiveSupport::StringInquirer.new("development")) do
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled, 'LogStruct should be disabled when LOGSTRUCT_ENABLED is "no"'
end
end
end
def test_enabled_env_var_takes_precedence_over_environment
# Set up test conditions
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test] # Test environment is enabled
# Use ClimateControl to modify ENV
ClimateControl.modify LOGSTRUCT_ENABLED: "false" do
# Stub Rails.env to match enabled_environments
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
refute LogStruct.config.enabled, "Env var should take precedence over environment"
end
end
end
def test_merge_rails_filter_parameters
# Store original filter keys
original_filter_keys = LogStruct.config.filters.filter_keys.dup
# Create a mock for Rails.application.config
# T.unsafe is needed to work around sorbet limitations in tests
# This is acceptable since this is just a test method
mock_config = T.unsafe(Object.new)
# Set up mock filter parameters with a mix of symbols and strings
filter_params = [:credit_card, "ssn", :password, "existing_key"]
clear_called = T.let(false, T::Boolean)
# Define necessary methods on our mock
mock_config.define_singleton_method(:filter_parameters) { filter_params }
mock_config.define_singleton_method(:respond_to?) do |method_name|
method_name.to_sym == :filter_parameters || super(method_name)
end
# Add a clear method to the filter_parameters array
filter_params.define_singleton_method(:clear) do
clear_called = true
filter_params.replace([])
end
# Set up mock Rails.application
mock_app = T.unsafe(Object.new)
mock_app.define_singleton_method(:config) { mock_config }
# Set our initial filter keys
LogStruct.config.filters.filter_keys = [:existing_key, :another_key]
# Stub Rails.application
Rails.stub(:application, mock_app) do
# Run the method we're testing
LogStruct.merge_rails_filter_parameters!
# Check that all Rails filter parameters were merged
assert_includes LogStruct.config.filters.filter_keys, :credit_card
assert_includes LogStruct.config.filters.filter_keys, :ssn
assert_includes LogStruct.config.filters.filter_keys, :password
assert_includes LogStruct.config.filters.filter_keys, :existing_key
assert_includes LogStruct.config.filters.filter_keys, :another_key
# Check that duplicates were removed (existing_key appears in both)
assert_equal 1, LogStruct.config.filters.filter_keys.count(:existing_key)
assert_equal 5, LogStruct.config.filters.filter_keys.size
# Verify Rails filter parameters were cleared
assert_empty filter_params
assert clear_called, "filter_parameters.clear should have been called"
end
# Restore original filter keys
LogStruct.config.filters.filter_keys = original_filter_keys
end
def test_merge_rails_filter_parameters_preserves_regex_filters
original_filter_keys = LogStruct.config.filters.filter_keys.dup
original_matchers = LogStruct.config.filters.filter_matchers.dup
regex_filter = /\Aapi_/i
filter_params = [regex_filter]
filter_params.define_singleton_method(:clear) do
T.unsafe(self).replace([])
end
mock_config = T.unsafe(Object.new)
mock_config.define_singleton_method(:filter_parameters) { filter_params }
mock_config.define_singleton_method(:respond_to?) do |method_name, include_private = false|
if method_name.to_sym == :filter_parameters
true
else
super(method_name, include_private)
end
end
mock_app = T.unsafe(Object.new)
mock_app.define_singleton_method(:config) { mock_config }
LogStruct.config.filters.filter_keys = []
Rails.stub(:application, mock_app) do
LogStruct.merge_rails_filter_parameters!
end
assert ParamFilters.should_filter_key?("api_token"), "regex-based Rails filters should continue filtering keys"
ensure
LogStruct.config.filters.filter_keys = T.must(original_filter_keys)
LogStruct.config.filters.filter_matchers = T.must(original_matchers)
end
# Test that development server process is DISABLED by default
# (development is not in enabled_environments by default)
def test_disabled_for_development_server_with_default_environments
LogStruct.config.enabled = true
# Use default enabled_environments: [:test, :production]
LogStruct.config.enabled_environments = [:test, :production]
original_argv = ::ARGV.dup
::ARGV.replace(["server"])
Rails.stub(:env, ActiveSupport::StringInquirer.new("development")) do
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled,
"LogStruct should be DISABLED for development server (development not in enabled_environments)"
end
ensure
::ARGV.replace(original_argv) if defined?(original_argv)
end
# Test server process detection
def test_enabled_for_server_process_in_production
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:production]
# Define Rails::Server to simulate server process
rails_server_class = Class.new
Object.const_set(:Rails, Module.new) unless defined?(::Rails)
::Rails.const_set(:Server, rails_server_class) unless defined?(::Rails::Server)
original_argv = ::ARGV.dup
::ARGV.replace(["server"])
Rails.stub(:env, ActiveSupport::StringInquirer.new("production")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LogStruct should be enabled for server process in production"
end
ensure
::ARGV.replace(original_argv) if defined?(original_argv)
::Rails.send(:remove_const, :Server) if defined?(::Rails::Server)
end
def test_disabled_for_console_in_production
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:production]
# Define Rails::Console to simulate console process
rails_console_class = Class.new
Object.const_set(:Rails, Module.new) unless defined?(::Rails)
::Rails.const_set(:Console, rails_console_class) unless defined?(::Rails::Console)
Rails.stub(:env, ActiveSupport::StringInquirer.new("production")) do
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled, "LogStruct should be disabled for console in production"
end
ensure
::Rails.send(:remove_const, :Console) if defined?(::Rails::Console)
end
def test_enabled_for_test_runs
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test]
# Test environment always enables JSON logging (both local and CI)
ClimateControl.modify CI: nil do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LogStruct should be enabled for all test runs"
end
end
end
def test_enabled_for_ci_test_runs
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test]
# CI=true should enable for test runs
ClimateControl.modify CI: "true" do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LogStruct should be enabled for CI test runs"
end
end
end
def test_enabled_regardless_of_ci_value
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test]
# Test environment enables JSON logging regardless of CI value
ClimateControl.modify CI: "false" do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LogStruct should be enabled in test environment regardless of CI value"
end
end
end
def test_disabled_for_rake_tasks_in_production
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:production]
# No Rails::Server, no Rails::Console, not test env
Rails.stub(:env, ActiveSupport::StringInquirer.new("production")) do
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled, "LogStruct should be disabled for rake tasks in production"
end
end
def test_logstruct_enabled_overrides_all_logic
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = []
# Even with console defined and no enabled environments, LOGSTRUCT_ENABLED=true should enable
rails_console_class = Class.new
Object.const_set(:Rails, Module.new) unless defined?(::Rails)
::Rails.const_set(:Console, rails_console_class) unless defined?(::Rails::Console)
ClimateControl.modify LOGSTRUCT_ENABLED: "true" do
Rails.stub(:env, ActiveSupport::StringInquirer.new("development")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "LOGSTRUCT_ENABLED=true should override all other logic"
end
end
ensure
::Rails.send(:remove_const, :Console) if defined?(::Rails::Console)
end
def test_console_disabled_even_in_ci
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test]
# Console should be disabled even in CI
rails_console_class = Class.new
Object.const_set(:Rails, Module.new) unless defined?(::Rails)
::Rails.const_set(:Console, rails_console_class) unless defined?(::Rails::Console)
ClimateControl.modify CI: "true" do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert_not LogStruct.config.enabled, "Console should be disabled even in CI"
end
end
ensure
::Rails.send(:remove_const, :Console) if defined?(::Rails::Console)
end
def test_various_ci_env_values
LogStruct.config.enabled = false
LogStruct.config.enabled_environments = [:test]
# Test various truthy CI values
%w[true 1 yes].each do |ci_value|
ClimateControl.modify CI: ci_value do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "CI=#{ci_value} should enable LogStruct in test"
end
end
# Reset for next iteration
LogStruct.config.enabled = false
end
# Test that empty string CI value still enables in test environment
ClimateControl.modify CI: "" do
Rails.stub(:env, ActiveSupport::StringInquirer.new("test")) do
LogStruct.set_enabled_from_rails_env!
assert LogStruct.config.enabled, "Test environment should be enabled regardless of CI value"
end
end
end
end
end