fixed all integration test issues

Author: ndbroadbent

.cspell/project-words.txt

@@ -19,6 +19,7 @@ Healthcheck
 Honeybadger
 hotwire
 hrefs
+kamal
 klass
 kwargs
 lightningcss

.ruby-version

@@ -1 +1 @@
-3.4.2
+3.4.5

CHANGELOG.md

@@ -7,4 +7,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [0.1.0] - 2025-09-07
 
-Initial release.
+Initial beta release.

Gemfile

@@ -11,7 +11,9 @@ unless ENV["RUBY_VERSION"]
   ruby File.read(File.expand_path(".ruby-version", __dir__)).strip
 end
 
-gem "rails", "~> #{ENV["RAILS_VERSION"] || "7.2.2.1"}", require: false
+# Use a stable Rails for gem development/test environment.
+# Rails version for the generated test app is controlled by RAILS_VERSION in rails_tests.
+gem "rails", "~> 8.0.2.1", require: false
 
 # Add these gems to silence Ruby 3.4+ warnings
 gem "bigdecimal"

Gemfile.lock

@@ -10,46 +10,45 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.2.2.1)
-      actionpack (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    actioncable (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
       zeitwerk (~> 2.6)
-    actionmailbox (7.2.2.1)
-      actionpack (= 7.2.2.1)
-      activejob (= 7.2.2.1)
-      activerecord (= 7.2.2.1)
-      activestorage (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    actionmailbox (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      activejob (= 8.0.2.1)
+      activerecord (= 8.0.2.1)
+      activestorage (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       mail (>= 2.8.0)
-    actionmailer (7.2.2.1)
-      actionpack (= 7.2.2.1)
-      actionview (= 7.2.2.1)
-      activejob (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    actionmailer (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      actionview (= 8.0.2.1)
+      activejob (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       mail (>= 2.8.0)
       rails-dom-testing (~> 2.2)
-    actionpack (7.2.2.1)
-      actionview (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    actionpack (8.0.2.1)
+      actionview (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       nokogiri (>= 1.8.5)
-      racc
-      rack (>= 2.2.4, < 3.2)
+      rack (>= 2.2.4)
       rack-session (>= 1.0.1)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
       useragent (~> 0.16)
-    actiontext (7.2.2.1)
-      actionpack (= 7.2.2.1)
-      activerecord (= 7.2.2.1)
-      activestorage (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    actiontext (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      activerecord (= 8.0.2.1)
+      activestorage (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.2.2.1)
-      activesupport (= 7.2.2.1)
+    actionview (8.0.2.1)
+      activesupport (= 8.0.2.1)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
@@ -59,22 +58,22 @@ GEM
       activemodel (>= 4.1)
       case_transform (>= 0.2)
       jsonapi-renderer (>= 0.1.1.beta1, < 0.3)
-    activejob (7.2.2.1)
-      activesupport (= 7.2.2.1)
+    activejob (8.0.2.1)
+      activesupport (= 8.0.2.1)
       globalid (>= 0.3.6)
-    activemodel (7.2.2.1)
-      activesupport (= 7.2.2.1)
-    activerecord (7.2.2.1)
-      activemodel (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    activemodel (8.0.2.1)
+      activesupport (= 8.0.2.1)
+    activerecord (8.0.2.1)
+      activemodel (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       timeout (>= 0.4.0)
-    activestorage (7.2.2.1)
-      actionpack (= 7.2.2.1)
-      activejob (= 7.2.2.1)
-      activerecord (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    activestorage (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      activejob (= 8.0.2.1)
+      activerecord (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       marcel (~> 1.0)
-    activesupport (7.2.2.1)
+    activesupport (8.0.2.1)
       base64
       benchmark (>= 0.3)
       bigdecimal
@@ -86,6 +85,7 @@ GEM
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ahoy_matey (5.4.0)
@@ -225,38 +225,38 @@ GEM
       stringio
     public_suffix (6.0.1)
     racc (1.8.1)
-    rack (3.1.11)
+    rack (3.1.16)
     rack-session (2.1.1)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
     rack-test (2.2.0)
       rack (>= 1.3)
     rackup (2.2.1)
       rack (>= 3)
-    rails (7.2.2.1)
-      actioncable (= 7.2.2.1)
-      actionmailbox (= 7.2.2.1)
-      actionmailer (= 7.2.2.1)
-      actionpack (= 7.2.2.1)
-      actiontext (= 7.2.2.1)
-      actionview (= 7.2.2.1)
-      activejob (= 7.2.2.1)
-      activemodel (= 7.2.2.1)
-      activerecord (= 7.2.2.1)
-      activestorage (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    rails (8.0.2.1)
+      actioncable (= 8.0.2.1)
+      actionmailbox (= 8.0.2.1)
+      actionmailer (= 8.0.2.1)
+      actionpack (= 8.0.2.1)
+      actiontext (= 8.0.2.1)
+      actionview (= 8.0.2.1)
+      activejob (= 8.0.2.1)
+      activemodel (= 8.0.2.1)
+      activerecord (= 8.0.2.1)
+      activestorage (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       bundler (>= 1.15.0)
-      railties (= 7.2.2.1)
+      railties (= 8.0.2.1)
     rails-dom-testing (2.2.0)
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.6.2)
       loofah (~> 2.21)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
-    railties (7.2.2.1)
-      actionpack (= 7.2.2.1)
-      activesupport (= 7.2.2.1)
+    railties (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
       irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
@@ -402,6 +402,7 @@ GEM
     unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
+    uri (1.0.3)
     useragent (0.16.11)
     websocket-driver (0.7.7)
       base64
@@ -428,7 +429,7 @@ PLATFORMS
 
 DEPENDENCIES
   active_model_serializers (~> 0.10.13)
-  ahoy_matey (~> 5.2)
+  ahoy_matey (>= 4.1, < 6.0)
   amazing_print
   bigdecimal
   bugsnag (~> 6.26)
@@ -445,7 +446,7 @@ DEPENDENCIES
   minitest-reporters (~> 1.6)
   mutex_m
   ostruct
-  rails (~> 7.2.2.1)
+  rails (~> 8.0.2.1)
   redcarpet
   rollbar (~> 3.4)
   rubocop
@@ -466,7 +467,7 @@ DEPENDENCIES
   yard-sorbet
 
 RUBY VERSION
-   ruby 3.4.2p28
+   ruby 3.4.5p51
 
 BUNDLED WITH
-   2.6.5
+   2.7.1

README.md

@@ -48,16 +48,29 @@ Please see the [documentation](https://logstruct.com/docs/configuration/) for co
 
 ### Important Notes on Integration
 
-Once initialized, the gem automatically includes its modules into the appropriate base classes:
+Once initialized (and enabled), the gem automatically includes its modules into the appropriate base classes:
 
-- `ActiveSupport::TaggedLogging` is patched to support both Hashes and Strings
+- `ActiveSupport::TaggedLogging` is patched to support both Hashes and Strings (only when LogStruct is enabled)
 - `ActionMailer::Base` includes error handling and event logging modules
 - We configure `Lograge` for request logging
 - A Rack middleware is inserted to catch and log errors, including security violations (IP spoofing, CSRF, blocked hosts, etc.)
 - Structured logging is set up for ActiveJob, Sidekiq, Shrine, etc.
 - Rails `config.filter_parameters` are merged into LogStruct's filters and then cleared (to avoid double filtering). Configure sensitive keys via `LogStruct.config.filters`.
 - When `RAILS_LOG_TO_STDOUT` is set, we log to STDOUT only. Otherwise, we log to STDOUT by default without adding a file appender to avoid duplicate logs.
 
+### Development behavior
+
+- Disabled by default in development. Enable explicitly via `LOGSTRUCT_ENABLED=true` or `LogStruct.configure { |c| c.enabled = true }`.
+- When enabled in development, LogStruct now defaults to production‑style JSON output so you can preview exactly what will be shipped in prod.
+- You can opt back into the colorful human formatter with:
+
+```ruby
+LogStruct.configure do |c|
+  c.integrations.prefer_json_in_development = false
+  c.integrations.enable_color_output = true
+end
+```
+
 ## Documentation
 
 Please see the [documentation](https://logstruct.com/docs) for more details. (All code examples are type-checked and tested, and it's harder to keep a README up to date.)

Rakefile

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
+require "rake/file_utils"
 require "rake/testtask"
 require "fileutils"
 
@@ -16,12 +17,5 @@ end
 # Load Sorbet tasks
 Dir.glob("tasks/*.rake").each { |r| load r }
 
-# Rails application integration tests
-desc "Run Rails integration tests"
-task :rails_tests do
-  script_path = File.expand_path("scripts/rails_tests.sh", __dir__)
-  system(script_path) || abort("Rails tests failed")
-end
-
 # Default task runs tests and type checking
 task default: [:test, "sorbet:typecheck"]

lib/log_struct.rb

@@ -12,9 +12,6 @@
 require "log_struct/concerns/configuration"
 require "log_struct/concerns/logging"
 
-# Monkey-patch ActiveSupport::TaggedLogging::Formatter to support hash input/output
-require "log_struct/monkey_patches/active_support/tagged_logging/formatter"
-
 # Require integrations
 require "log_struct/integrations"
 

lib/log_struct/config_struct/integrations.rb

@@ -64,6 +64,12 @@ class Integrations < T::Struct
       # Default: true
       prop :enable_color_output, T::Boolean, default: true
 
+      # Prefer production-style JSON output in development when LogStruct is enabled.
+      # This makes it easy to preview exactly what production logs will look like
+      # when you opt-in to LogStruct locally (via LOGSTRUCT_ENABLED=true or config).
+      # Default: true
+      prop :prefer_json_in_development, T::Boolean, default: true
+
       # Color configuration for JSON output
       # Default: nil (uses SemanticLogger defaults)
       prop :color_map, T.nilable(T::Hash[Symbol, Symbol]), default: nil

lib/log_struct/integrations/lograge.rb

@@ -38,21 +38,30 @@ def configure_lograge(logstruct_config)
             # The struct is converted to JSON by our Formatter (after filtering, etc.)
             config.lograge.formatter = T.let(
               lambda do |data|
+                # Coerce common fields to expected types
+                status = ((s = data[:status]) && s.respond_to?(:to_i)) ? s.to_i : s
+                duration = ((d = data[:duration]) && d.respond_to?(:to_f)) ? d.to_f : d
+                view = ((v = data[:view]) && v.respond_to?(:to_f)) ? v.to_f : v
+                db = ((b = data[:db]) && b.respond_to?(:to_f)) ? b.to_f : b
+
+                params = data[:params]
+                params = params.deep_symbolize_keys if params&.respond_to?(:deep_symbolize_keys)
+
                 # Convert the data hash to a Log::Request struct
                 Log::Request.new(
                   source: Source::Rails,
                   event: Event::Request,
                   timestamp: Time.now,
-                  http_method: data[:method],
-                  path: data[:path],
-                  format: data[:format],
-                  controller: data[:controller],
-                  action: data[:action],
-                  status: data[:status],
-                  duration: data[:duration],
-                  view: data[:view],
-                  db: data[:db],
-                  params: data[:params]
+                  http_method: data[:method]&.to_s,
+                  path: data[:path]&.to_s,
+                  format: data[:format]&.to_s,
+                  controller: data[:controller]&.to_s,
+                  action: data[:action]&.to_s,
+                  status: status,
+                  duration: duration,
+                  view: view,
+                  db: db,
+                  params: params
                 )
               end,
               T.proc.params(hash: T::Hash[Symbol, T.untyped]).returns(Log::Request)