fixed all linting issues

Author: ndbroadbent

.cspell/project-words.txt

@@ -1,4 +1,6 @@
 ankane
+appender
+appenders
 autorun
 bindir
 binstub
@@ -10,6 +12,7 @@ creds
 dalli
 favicons
 gettime
+goodjob
 Healthcheck
 Honeybadger
 hotwire
@@ -21,6 +24,7 @@ LogStruct
 metaprogramming
 nilable
 optparse
+parseable
 pentester
 pentesters
 procs

lib/log_struct/formatter.rb

@@ -210,12 +210,12 @@ def generate_json(data)
     sig { params(array: T::Array[T.untyped]).returns(T::Boolean) }
     def looks_like_backtrace?(array)
       return false if array.empty?
-      
+
       # Check if most elements look like backtrace lines (file.rb:123 or similar patterns)
       backtrace_like_count = array.first(5).count do |element|
         element.is_a?(String) && element.match?(/\A[^:\s]+:\d+/)
       end
-      
+
       # If at least 3 out of the first 5 elements look like backtrace lines, treat as backtrace
       backtrace_like_count >= 3
     end

lib/log_struct/integrations/good_job.rb

@@ -35,7 +35,7 @@ module Integrations
     # ## Configuration:
     # The integration is automatically enabled when GoodJob is detected and
     # LogStruct configuration allows it. It can be disabled by setting:
-    # 
+    #
     # ```ruby
     # config.integrations.enable_goodjob = false
     # ```
@@ -44,7 +44,7 @@ module GoodJob
       extend IntegrationInterface
 
       # Set up GoodJob structured logging
-      # 
+      #
       # This method configures GoodJob to use LogStruct's structured logging
       # by replacing the default logger and subscribing to job events.
       #
@@ -70,8 +70,8 @@ def self.setup(config)
       def self.configure_logger
         return unless defined?(::GoodJob)
 
-        # Use T.unsafe to avoid Sorbet errors with external constants
-        goodjob_module = T.unsafe(Object.const_get("GoodJob"))
+        # Use direct reference to avoid const_get - GoodJob is guaranteed to be defined here
+        goodjob_module = T.unsafe(GoodJob)
 
         # Replace GoodJob.logger with our structured logger if GoodJob is available
         if goodjob_module.respond_to?(:logger=)
@@ -108,4 +108,4 @@ def self.subscribe_to_notifications
       private_class_method :subscribe_to_notifications
     end
   end
-end
+end

lib/log_struct/integrations/good_job/log_subscriber.rb

@@ -41,7 +41,7 @@ class LogSubscriber < ::ActiveSupport::LogSubscriber
         sig { params(event: T.untyped).void }
         def enqueue(event)
           job_data = extract_job_data(event)
-          
+
           log_entry = LogStruct::Log::GoodJob.new(
             event: Event::Enqueue,
             level: Level::Info,
@@ -64,7 +64,7 @@ def enqueue(event)
         sig { params(event: T.untyped).void }
         def start(event)
           job_data = extract_job_data(event)
-          
+
           log_entry = LogStruct::Log::GoodJob.new(
             event: Event::Start,
             level: Level::Info,
@@ -82,11 +82,11 @@ def start(event)
           logger.info(log_entry)
         end
 
-        # Job completed successfully event  
+        # Job completed successfully event
         sig { params(event: T.untyped).void }
         def finish(event)
           job_data = extract_job_data(event)
-          
+
           log_entry = LogStruct::Log::GoodJob.new(
             event: Event::Finish,
             level: Level::Info,
@@ -110,7 +110,7 @@ def finish(event)
         sig { params(event: T.untyped).void }
         def error(event)
           job_data = extract_job_data(event)
-          
+
           log_entry = LogStruct::Log::GoodJob.new(
             event: Event::Error,
             level: Level::Error,
@@ -134,7 +134,7 @@ def error(event)
         sig { params(event: T.untyped).void }
         def schedule(event)
           job_data = extract_job_data(event)
-          
+
           log_entry = LogStruct::Log::GoodJob.new(
             event: Event::Schedule,
             level: Level::Info,
@@ -166,7 +166,7 @@ def extract_job_data(event)
           # Basic job information
           if job
             data[:job_id] = job.job_id if job.respond_to?(:job_id)
-            data[:job_class] = job.job_class if job.respond_to?(:job_class)  
+            data[:job_class] = job.job_class if job.respond_to?(:job_class)
             data[:queue_name] = job.queue_name if job.respond_to?(:queue_name)
             data[:arguments] = job.arguments if job.respond_to?(:arguments)
             data[:priority] = job.priority if job.respond_to?(:priority)
@@ -210,7 +210,7 @@ def calculate_wait_time(execution)
           return nil unless execution.created_at && execution.performed_at
 
           (execution.performed_at - execution.created_at).to_f
-        rescue => e
+        rescue
           # Return nil if calculation fails
           nil
         end
@@ -225,4 +225,4 @@ def logger
       end
     end
   end
-end
+end

lib/log_struct/integrations/good_job/logger.rb

@@ -33,7 +33,7 @@ class Logger < LogStruct::SemanticLogger::Logger
           define_method(level) do |message = nil, payload = nil, &block|
             # Extract basic job context from thread-local variables
             job_context = {}
-            
+
             if Thread.current[:good_job_execution]
               execution = Thread.current[:good_job_execution]
               if execution.respond_to?(:job_id)
@@ -62,12 +62,12 @@ class Logger < LogStruct::SemanticLogger::Logger
                 message: message || (block ? block.call : "")
               }
             )
-            
+
             # Pass the struct to SemanticLogger
             super(log_struct, payload, &nil)
           end
         end
       end
     end
   end
-end
+end

lib/log_struct/log/good_job.rb

@@ -28,7 +28,7 @@ module Log
     # - Thread and process information
     #
     # ## Usage Examples:
-    # 
+    #
     # ```ruby
     # # Job execution logging
     # LogStruct::Log::GoodJob.new(
@@ -148,4 +148,4 @@ def serialize(strict = true)
       end
     end
   end
-end
+end

lib/log_struct/semantic_logger/formatter.rb

@@ -20,7 +20,7 @@ module SemanticLogger
     # - **Type-optimized paths**: Fast serialization for common data types
     # - **Zero-copy operations**: Minimal memory allocation during serialization
     #
-    # ### Memory Efficiency  
+    # ### Memory Efficiency
     # - **Object reuse**: Formatter instances are reused across log calls
     # - **Lazy evaluation**: Only processes data that will be included in output
     # - **Efficient buffering**: Optimal buffer sizes for JSON generation

lib/log_struct/semantic_logger/setup.rb

@@ -177,7 +177,7 @@ def self.determine_filter
       #
       # ## Benefits of Complete Logger Replacement:
       # - **Consistent performance**: All Rails components benefit from SemanticLogger speed
-      # - **Unified formatting**: All logs use the same structured JSON format  
+      # - **Unified formatting**: All logs use the same structured JSON format
       # - **Centralized configuration**: Single point of control for all logging
       # - **Complete compatibility**: Maintains all Rails.logger API contracts
       #

site/app/docs/comparison/page.tsx

@@ -234,7 +234,7 @@ function ComparisonTable() {
       return (
         <Minus className="w-5 h-5 text-yellow-600 dark:text-yellow-500 mx-auto" />
       );
-    return <span className="text-xs">{value}</span>;
+    return <span className="text-xs">{String(value)}</span>;
   };
 
   return (

site/lib/__tests__/codeExamples.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeAll } from '@jest/globals';
+// Jest globals are available in test environment without explicit import
 import fs from 'fs';
 import path from 'path';
 import {