Skip to content

Commit 54eadef

Browse files
committed
fixes
1 parent 6b93db5 commit 54eadef

File tree

5 files changed

+17
-14
lines changed

5 files changed

+17
-14
lines changed

site/app/docs/page.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,7 @@ export default function DocsPage() {
7575
</CodeBlock>
7676
<Callout className="mt-4">
7777
This approach is ideal for most applications. No knowledge of
78-
Sorbet is required and you don&apos;t need to worry about
79-
type-checking.
78+
Sorbet is required.
8079
</Callout>
8180
</TabsContent>
8281
<TabsContent value="typed" className="mt-0.5">

site/app/docs/supported-gem-versions/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { HeadingWithAnchor } from '@/components/heading-with-anchor';
22
import { EditPageLink } from '@/components/edit-page-link';
3-
import { parseGemspec, GemDependency } from '@/lib/gemspec-parser';
3+
import { parseGemspec } from '@/lib/gemspec-parser';
44
import { Card } from '@/components/ui/card';
55
import { Callout } from '@/components/ui/callout';
66

site/components/log-scroller.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,11 @@ export function LogScroller() {
291291
style={{ boxShadow: '0 1px 1px rgba(0, 0, 0, 0.2)' }}
292292
onClick={(e) => {
293293
e.stopPropagation();
294-
isMaximized ? handleRestore() : handleMaximize();
294+
if (isMaximized) {
295+
handleRestore();
296+
} else {
297+
handleMaximize();
298+
}
295299
}}
296300
title={isMaximized ? 'Click to restore' : 'Click to maximize'}
297301
></div>

test/code_examples/configuration_test.rb

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,23 +72,24 @@ def test_typed_logging
7272
# ----------------------------------------------------------
7373
# BEGIN CODE EXAMPLE: typed_logging
7474
# ----------------------------------------------------------
75-
# Create a typed request log entry
76-
request_log = LogStruct::Log::Request.new(
77-
source: LogStruct::Source::Rails,
78-
http_method: "GET",
79-
path: "/users",
80-
status: 200,
81-
duration: 45.2
75+
# Create a typed log entry
76+
log = LogStruct::Log::Plain.new(
77+
source: LogStruct::Source::App,
78+
message: "User signed in",
79+
additional_data: {
80+
user_id: 123,
81+
ip_address: "192.168.1.1"
82+
}
8283
)
8384

8485
# Log the typed struct
85-
Rails.logger.info(request_log)
86+
Rails.logger.info(log)
8687
# ----------------------------------------------------------
8788
# END CODE EXAMPLE: typed_logging
8889
# ----------------------------------------------------------
8990

9091
# Simple assertion to make the test pass
91-
assert_instance_of LogStruct::Log::Request, request_log
92+
assert_instance_of LogStruct::Log::Plain, log
9293
end
9394

9495
def test_basic_configuration

test/log_struct/configuration_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ def test_enabled_environment_takes_precedence_over_env_var
104104
end
105105

106106
def test_merge_rails_filter_parameters
107-
108107
# Store original filter keys
109108
original_filter_keys = LogStruct.config.filters.filter_keys.dup
110109

0 commit comments

Comments
 (0)