fixes for deprecation warnings and rails 8

Author: ndbroadbent

Gemfile

@@ -13,10 +13,11 @@ end
 
 gem "rails", "~> #{ENV["RAILS_VERSION"] || "7.2.2.1"}", require: false
 
-# Add these gems to silence Ruby 3.4 warnings
+# Add these gems to silence Ruby 3.4+ warnings
 gem "bigdecimal"
 gem "drb"  # For ActiveSupport::TestCase
 gem "mutex_m"
+gem "ostruct"  # For Ruby 3.5+ compatibility
 
 # Sorbet is needed for development
 gem "sorbet", "~> 0.5"

Gemfile.lock

@@ -428,6 +428,7 @@ DEPENDENCIES
   minitest (~> 5.20)
   minitest-reporters (~> 1.6)
   mutex_m
+  ostruct
   rails (~> 7.2.2.1)
   redcarpet
   rollbar (~> 3.4)

lib/log_struct/formatter.rb

@@ -90,7 +90,9 @@ def process_values(arg, recursion_depth: 0)
             when ActiveRecord::Base
               "#{arg.class}(##{arg.id})"
             else
-              arg
+              # For non-ActiveRecord objects that failed to_global_id, try to get a string representation
+              # If this also fails, we want to catch it and return the error placeholder
+              T.unsafe(arg).to_s
             end
           rescue => e
             LogStruct.handle_exception(e, source: Source::LogStruct)

test/log_struct/formatter_test.rb

@@ -82,6 +82,15 @@ def test_handles_global_id_errors_gracefully
         def to_global_id
           raise StandardError, "Can't serialize"
         end
+
+        # In Rails 8.0+, ensure any fallback methods also raise to trigger error path
+        def inspect
+          raise StandardError, "Can't inspect"
+        end
+
+        def to_s
+          raise StandardError, "Can't stringify"
+        end
       end
 
       # Create an instance of it

test/log_struct/multi_error_reporter_test.rb

@@ -17,6 +17,9 @@ def setup
       @original_stdout = $stdout
       @stdout_buffer = StringIO.new
       $stdout = @stdout_buffer
+
+      # Define mock constants for error reporting services if they don't exist
+      setup_mock_constants
     end
 
     def teardown
@@ -206,5 +209,82 @@ def test_report_error_with_no_service
         end
       end
     end
+
+    private
+
+    def setup_mock_constants
+      # Define mock constants for error reporting services if they don't exist
+      unless defined?(::Sentry)
+        sentry_class = Class.new do
+          def self.capture_exception(*args)
+            # Mock implementation
+          end
+
+          def self.stub(method, &block)
+            # Mock stub method for minitest
+            original_method = singleton_method(method)
+            define_singleton_method(method, &block)
+            yield
+          ensure
+            define_singleton_method(method, original_method.to_proc) if original_method
+          end
+        end
+        Object.const_set(:Sentry, sentry_class)
+      end
+
+      unless defined?(::Bugsnag)
+        bugsnag_class = Class.new do
+          def self.notify(*args)
+            # Mock implementation
+          end
+
+          def self.stub(method, &block)
+            # Mock stub method for minitest
+            original_method = singleton_method(method)
+            define_singleton_method(method, &block)
+            yield
+          ensure
+            define_singleton_method(method, original_method.to_proc) if original_method
+          end
+        end
+        Object.const_set(:Bugsnag, bugsnag_class)
+      end
+
+      unless defined?(::Rollbar)
+        rollbar_class = Class.new do
+          def self.error(*args)
+            # Mock implementation
+          end
+
+          def self.stub(method, &block)
+            # Mock stub method for minitest
+            original_method = singleton_method(method)
+            define_singleton_method(method, &block)
+            yield
+          ensure
+            define_singleton_method(method, original_method.to_proc) if original_method
+          end
+        end
+        Object.const_set(:Rollbar, rollbar_class)
+      end
+
+      unless defined?(::Honeybadger)
+        honeybadger_class = Class.new do
+          def self.notify(*args)
+            # Mock implementation
+          end
+
+          def self.stub(method, &block)
+            # Mock stub method for minitest
+            original_method = singleton_method(method)
+            define_singleton_method(method, &block)
+            yield
+          ensure
+            define_singleton_method(method, original_method.to_proc) if original_method
+          end
+        end
+        Object.const_set(:Honeybadger, honeybadger_class)
+      end
+    end
   end
 end

test/test_helper.rb

@@ -68,6 +68,9 @@ def self.eager_load_frameworks
     [:password, :token, :secret, :key, :access, :auth, :credentials],
     T::Array[Symbol]
   )
+
+  # Fix Rails 8.1 deprecation warning for to_time timezone preservation
+  config.active_support.to_time_preserves_timezone = :zone
 end
 
 # Initialize the application