populate all optional fields in random logs

Author: ndbroadbent

scripts/generate_typescript_structs.rb

@@ -343,10 +343,9 @@ def self.generate_source_ts(payload)
       if ts_source_const == "Source"
         lines << "      source: (gen.sample(Object.values(Source) as unknown as Source[])),"
       end
-      # Required fields get random defaults with precedence:
+      # Populate defaults for all fields with precedence:
       # schema sample_type > SampleByLogField > base type fallback
       (payload.base_fields + event_only).each do |f|
-        next unless f.required
         ts = ts_type(f.sorbet_type)
         base = case ts
         when "string" then "'sample'"

site/app/docs/logging/page.tsx

@@ -77,32 +77,6 @@ logger.formatter = config.log_formatter
 config.logger = ActiveSupport::TaggedLogging.new(logger)`}
       </CodeBlock>
 
-      <HeadingWithAnchor id="dotenv-rails" level={2}>
-        Dotenv‑Rails and Early Boot Logs
-      </HeadingWithAnchor>
-      <p className="text-neutral-600 dark:text-neutral-400">
-        Some libraries (e.g., <code>dotenv-rails</code>) log very early during
-        boot. LogStruct subscribes to those notifications immediately and
-        buffers structured logs. After your initializers run, LogStruct decides
-        which set to emit:
-      </p>
-      <ul className="list-disc list-inside space-y-2 text-neutral-600 dark:text-neutral-400">
-        <li>
-          <b>Enabled:</b> Emit structured JSON logs (for example, a dotenv{' '}
-          <em>update</em> event) and suppress original replay.
-        </li>
-        <li>
-          <b>Disabled:</b> Emit original <code>[dotenv]</code> lines and discard
-          the structured buffer.
-        </li>
-      </ul>
-      <Callout type="warning" className="mt-2">
-        When you run a <code>rails runner</code> inside your test suite, it
-        inherits <code>RAILS_ENV=test</code>. Dotenv may have already loaded{' '}
-        <code>.env.test</code>, so nested runs might only show a single “Loaded
-        …” line (no “Set …” update).
-      </Callout>
-
       <HeadingWithAnchor id="production-recommendations" level={2}>
         Production Recommendations
       </HeadingWithAnchor>
@@ -121,19 +95,6 @@ config.logger = ActiveSupport::TaggedLogging.new(logger)`}
         </li>
       </ul>
 
-      <HeadingWithAnchor id="quick-diagnostics" level={2}>
-        Quick Diagnostics
-      </HeadingWithAnchor>
-      <CodeBlock language="bash">
-        {`# Verify structured boot logs (dotenv) in test env
-LOGSTRUCT_ENABLED=true RAILS_LOG_TO_STDOUT=1 DISABLE_SPRING=1 RAILS_ENV=test \
-  rails runner 'puts LogStruct.enabled?'
-
-# Verify original dotenv lines when disabled
-LOGSTRUCT_ENABLED=false RAILS_LOG_TO_STDOUT=1 DISABLE_SPRING=1 RAILS_ENV=development \
-  rails runner 'puts LogStruct.enabled?'`}
-      </CodeBlock>
-
       <EditPageLink />
     </div>
   );

site/lib/log-generation/log-generator.ts

@@ -153,10 +153,18 @@ export class LogGenerator extends RandomDataGenerator {
       case LogType.ACTIONMAILER: {
         switch (evt ?? this.sample([Event.Delivery, Event.Delivered])) {
           case Event.Delivered:
-            return ActionMailer.ActionMailerDelivered.random(this).serialize();
+            return ActionMailer.ActionMailerDelivered.random(this, {
+              to: [this.randomEmail()],
+              from: 'no-reply@example.com',
+              subject: 'Welcome!',
+            }).serialize();
           case Event.Delivery:
           default:
-            return ActionMailer.ActionMailerDelivery.random(this).serialize();
+            return ActionMailer.ActionMailerDelivery.random(this, {
+              to: [this.randomEmail()],
+              from: 'no-reply@example.com',
+              subject: 'Welcome!',
+            }).serialize();
         }
       }