Skip to content

Commit ba5a71c

Browse files
committed
rubocop-rails is way too annoying
1 parent d5bbb2d commit ba5a71c

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

.rubocop.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ inherit_gem:
1010

1111
AllCops:
1212
NewCops: enable
13+
SuggestExtensions:
14+
rubocop-rails: false
1315
Exclude:
1416
- node_modules/**/*
1517
- public/**/*

bin/rails_tests

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ fi
3535

3636
# Only recreate the app if FORCE_RECREATE is set or the app doesn't exist
3737
if [ "$FORCE_RECREATE" = "true" ] && [ -d "$TEST_APP_DIR" ]; then
38-
echo "Force recreating test app..."
38+
echo "Removing existing test app: $TEST_APP_DIR"
3939
rm -rf "$TEST_APP_DIR"
4040
fi
4141

rails_test_app/create_app.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
require "fileutils"
4343
require "rails/version"
4444
require "erb"
45+
require "sorbet-runtime"
4546

4647
# Path constants
4748
ROOT_DIR = File.expand_path("..", __dir__)
@@ -63,7 +64,7 @@
6364
skip_app_creation = ENV["SKIP_APP_CREATION"] == "true"
6465

6566
# Extract major and minor version for migrations and load_defaults
66-
@rails_major_minor = rails_version.split(".")[0..1].join(".")
67+
@rails_major_minor = T.must(rails_version.split(".")[0..1]).join(".")
6768

6869
# Create directories
6970
FileUtils.mkdir_p(RAILS_APP_DIR)
@@ -178,11 +179,11 @@ def copy_template(file, target_path = nil)
178179
copy_template(relative_path)
179180
end
180181

181-
# Run bundle install again to ensure all dependencies are correctly resolved
182-
puts "Running final bundle install..."
183-
Dir.chdir(RAILS_APP_DIR) do
184-
system(clean_env, "bundle install") || abort("Bundle install failed")
185-
end
182+
# # Run bundle install again to ensure all dependencies are correctly resolved
183+
# puts "Running final bundle install..."
184+
# Dir.chdir(RAILS_APP_DIR) do
185+
# system(clean_env, "bundle install") || abort("Bundle install failed")
186+
# end
186187

187188
# Set up the database
188189
puts "Setting up Rails application in #{RAILS_APP_DIR}..."

0 commit comments

Comments
 (0)