fix tapioca issue with types - can't use the "LogStruct" name as a value for an enum

Author: ndbroadbent

lib/log_struct.rb

@@ -4,7 +4,7 @@
 # Core library files
 require "log_struct/sorbet"
 require "log_struct/version"
-require "log_struct/enums"  # All enums are now in the enums directory
+require "log_struct/enums"
 require "log_struct/configuration"
 require "log_struct/formatter"
 require "log_struct/railtie"

lib/log_struct/concerns/error_handling.rb

@@ -21,7 +21,7 @@ def error_handling_mode_for(source)
           case source
           when Source::TypeChecking
             config.error_handling_modes.type_checking_errors
-          when Source::LogStruct
+          when Source::Internal
             config.error_handling_modes.logstruct_errors
           when Source::Security
             config.error_handling_modes.security_errors

lib/log_struct/enums/source.rb

@@ -7,8 +7,9 @@ class Source < T::Enum
     enums do
       # Error sources
       TypeChecking = new(:type_checking) # For type checking errors (Sorbet)
-      LogStruct = new(:logstruct) # Errors from LogStruct itself
       Security = new(:security) # Security-related events
+      # Errors from LogStruct. (Cannot use LogStruct here because it confuses tapioca.)
+      Internal = new(:logstruct)
 
       # Application sources
       Rails = new(:rails) # For request-related logs/errors

lib/log_struct/formatter.rb

@@ -94,7 +94,7 @@ def process_values(arg, recursion_depth: 0)
               T.unsafe(arg).to_s
             end
           rescue => e
-            LogStruct.handle_exception(e, source: Source::LogStruct)
+            LogStruct.handle_exception(e, source: Source::Internal)
             "[GLOBALID_ERROR]"
           end
         end
@@ -115,7 +115,7 @@ def process_values(arg, recursion_depth: 0)
         value_type: arg.class.name,
         recursion_depth: recursion_depth
       }
-      LogStruct.handle_exception(e, source: Source::LogStruct, context: context)
+      LogStruct.handle_exception(e, source: Source::Internal, context: context)
       arg
     end
 
@@ -166,7 +166,7 @@ def log_value_to_hash(log_value, time:)
               object_class: log_value.class.name,
               object_inspect: log_value.inspect.truncate(100)
             }
-            LogStruct.handle_exception(e, source: Source::LogStruct, context: context)
+            LogStruct.handle_exception(e, source: Source::Internal, context: context)
 
             # Fall back to the string representation to ensure we continue processing
             log_value.to_s

lib/log_struct/integrations/active_record.rb

@@ -58,7 +58,7 @@ def self.subscribe_to_sql_notifications
         ::ActiveSupport::Notifications.subscribe("sql.active_record") do |name, start, finish, id, payload|
           handle_sql_event(name, start, finish, id, payload)
         rescue => error
-          LogStruct.handle_exception(error, source: LogStruct::Source::LogStruct)
+          LogStruct.handle_exception(error, source: LogStruct::Source::Internal)
         end
       end
 

lib/log_struct/multi_error_reporter.rb

@@ -136,7 +136,7 @@ def fallback_logging(error, context = {})
 
         # Create a proper error log entry
         error_log = Log::Error.from_exception(
-          Source::LogStruct,
+          Source::Internal,
           error,
           context
         )

sorbet/rbi/annotations/actionpack.rbi

@@ -391,7 +391,7 @@ class ActiveRecordTest < ActiveSupport::TestCase
         first_exception = T.let(exceptions_logged.first, T.nilable(T::Array[T.untyped]))
 
         assert_not_nil first_exception
-        assert_equal LogStruct::Source::LogStruct, T.must(first_exception)[1]
+        assert_equal LogStruct::Source::Internal, T.must(first_exception)[1]
       end
 
       test "integration is included in automatic setup" do