fixed all issues

Author: ndbroadbent

.rubocop.yml

@@ -18,6 +18,7 @@ AllCops:
     - sorbet/rbi/dsl/**/*
     - sorbet/rbi/gems/**/*
     - sorbet/rbi/annotations/**/*
+    - rails_test_app/logstruct_test_app/bin/**/*
 
 Layout/MultilineHashKeyLineBreaks:
   Enabled: true
@@ -40,6 +41,8 @@ Rails/Output:
   Enabled: false
 Rails/NegateInclude:
   Enabled: false
+Rails/RefuteMethods:
+  Enabled: false
 
 Performance/OpenStruct:
   Exclude:

site/app/page.tsx

@@ -136,8 +136,8 @@ export default function Home() {
               <h3 className="text-xl font-semibold">Type-safe with Sorbet</h3>
             </div>
             <p className="text-neutral-600 dark:text-neutral-400">
-              LogStruct is fully type-checked with Sorbet so your logs are
-              always structured correctly and have the right data.
+              LogStruct is fully type-checked with Sorbet. Your logs are
+              guaranteed to have the correct structure and valid data.
             </p>
           </div>
           <div className="rounded-lg border border-neutral-200 p-6 dark:border-neutral-800">

site/lib/log-generation/log-generator.ts

@@ -211,8 +211,8 @@ export class LogGenerator extends RandomDataGenerator {
   private generateActiveJobLog(
     log: Partial<ActiveJobLog>,
   ): Partial<ActiveJobLog> {
-    // Add specific fields for ActiveJobLog
-    const jobLog: Partial<ActiveJobLog> = {
+    // Create the basic job log without duration
+    const baseJobLog: Partial<ActiveJobLog> = {
       ...log,
       job_id: this.randomHex(8),
       job_class: this.sample(SampleData.JOB_CLASSES),
@@ -223,14 +223,18 @@ export class LogGenerator extends RandomDataGenerator {
         this.randomInt(1, 100),
         { action: this.sample(['create', 'update', 'process']) },
       ],
-      // Only set duration if it's a FINISH event
-      duration: log.event === LogEvent.FINISH ? this.randomDuration() : 0,
       data: {
         retries: this.randomInt(0, 3),
         scheduled_at: this.randomTimestamp(),
       },
     };
 
+    // Only add duration if it's a FINISH event
+    const jobLog: Partial<ActiveJobLog> =
+      log.event === LogEvent.FINISH
+        ? { ...baseJobLog, duration: this.randomDuration() }
+        : baseJobLog;
+
     return jobLog;
   }
 
@@ -437,7 +441,6 @@ export class LogGenerator extends RandomDataGenerator {
       job_class: jobClass,
       queue_name: queueName,
       arguments: args,
-      duration: 0,
       data,
     };
 
@@ -455,7 +458,6 @@ export class LogGenerator extends RandomDataGenerator {
       job_class: jobClass,
       queue_name: queueName,
       arguments: args,
-      duration: 0,
       data,
     };
 

test/tools/log_types_exporter_test.rb

@@ -184,6 +184,7 @@ def test_security_log_event_union_type
     # Verify we extracted the correct enum values - sort both arrays to avoid order issues
     expected_values = ["IPSpoof", "CSRFViolation", "BlockedHost"].sort
     extracted_values = type_info[:enum_values].sort
+
     assert_equal expected_values, extracted_values, "Should extract the correct enum values"
 
     # Test the resulting TypeScript type
@@ -203,9 +204,11 @@ def test_security_log_event_union_type
     # Check that the SecurityLog interface has the event field with a union type
     # We don't check the exact string since the order may vary
     security_log_section = content.match(/export interface SecurityLog \{.*?\}/m)
+
     assert security_log_section, "Should find SecurityLog interface in the generated TypeScript"
 
     event_line = security_log_section[0].lines.find { |line| line.strip.start_with?("event:") }
+
     assert event_line, "SecurityLog interface should have an event field"
 
     # Verify that the event line contains all three enum values and union operators
@@ -229,61 +232,72 @@ def test_single_enum_value_restriction
 
     # Test the resulting TypeScript type
     ts_type = @exporter.typescript_type_for(type_info)
+
     assert_equal "Source.JOB", ts_type, "TypeScript type should be the specific enum value"
 
     # Now check that the full TypeScript generation includes this restricted type
     content = @exporter.generate_typescript_definitions
 
     # Find the ActiveJobLog interface section
     job_log_section = content.match(/export interface ActiveJobLog \{.*?\}/m)
+
     assert job_log_section, "Should find ActiveJobLog interface in the generated TypeScript"
 
     # Extract the source line and check if it has the specific enum value
     source_line = job_log_section[0].lines.find { |line| line.strip.start_with?("source:") }
+
     assert source_line, "ActiveJobLog interface should have a source field"
 
     # The source field should be a specific enum value, not a generic Source enum
-    assert_equal "source: Source.JOB;", source_line.strip,
+    assert_equal "source: Source.JOB;",
+      source_line.strip,
       "source field should be Source.JOB specifically, not just Source"
     refute_includes source_line, "Source;", "source field should not be the general Source enum"
   end
-  
+
   def test_exports_log_event_type_arrays
     # Test that we export valid event type arrays for each log type
     content = @exporter.generate_typescript_definitions
-    
+
     # Check Security log events array
     security_array_match = content.match(/export const SecurityLogEvents: Array<(.*?)> = \[(.*?)\]/m)
+
     assert security_array_match, "Should export a SecurityLogEvents array"
-    
+
     # Check the union type for the array
     security_type = security_array_match[1]
+
     ["LogEvent.BLOCKED_HOST", "LogEvent.CSRF_VIOLATION", "LogEvent.IP_SPOOF"].each do |event|
       assert_includes security_type, event, "SecurityLogEvents type should contain #{event}"
     end
-    
+
     # Check the array content
     security_array_content = security_array_match[2]
+
     ["LogEvent.BLOCKED_HOST", "LogEvent.CSRF_VIOLATION", "LogEvent.IP_SPOOF"].each do |event|
       assert_includes security_array_content, event, "SecurityLogEvents array should contain #{event}"
     end
-    
+
     # Check ActiveJob log events array
     activejob_array_match = content.match(/export const ActiveJobLogEvents: Array<(.*?)> = \[(.*?)\]/m)
+
     assert activejob_array_match, "Should export an ActiveJobLogEvents array"
-    
+
     # Check the array content
     activejob_array_content = activejob_array_match[2]
+
     ["LogEvent.ENQUEUE", "LogEvent.START", "LogEvent.FINISH", "LogEvent.SCHEDULE"].each do |event|
       assert_includes activejob_array_content, event, "ActiveJobLogEvents array should contain #{event}"
     end
-    
+
     # Check ActiveStorage log events array
     storage_array_match = content.match(/export const ActiveStorageLogEvents: Array<(.*?)> = \[(.*?)\]/m)
+
     assert storage_array_match, "Should export an ActiveStorageLogEvents array"
-    
+
     # Check the array content
     storage_array_content = storage_array_match[2]
+
     ["LogEvent.UPLOAD", "LogEvent.DOWNLOAD", "LogEvent.DELETE", "LogEvent.STREAM"].each do |event|
       assert_includes storage_array_content, event, "ActiveStorageLogEvents array should contain #{event}"
     end

tools/log_types_exporter.rb

@@ -146,32 +146,32 @@ def generate_typescript(data)
 
         # Add interface for each log type
         ts_content << "// Log Interfaces"
-        
+
         # Collect all event union types to generate arrays later
         log_event_arrays = {}
-        
+
         data[:logs].each do |log_type, log_info|
           ts_content << "export interface #{log_type}Log {"
-          
+
           # Collect valid event types if this log has an enum_union for events
           event_field_info = log_info[:fields][:event]
-          if event_field_info && 
-             event_field_info[:type] == "enum_union" &&
-             event_field_info[:base_enum] == "LogEvent" && 
-             event_field_info[:enum_values]&.any?
-            
+          if event_field_info &&
+              event_field_info[:type] == "enum_union" &&
+              event_field_info[:base_enum] == "LogEvent" &&
+              event_field_info[:enum_values]&.any?
+
             log_event_arrays[log_type] = event_field_info[:enum_values].map do |value|
               # Map Ruby enum names to TypeScript enum values (e.g., "IPSpoof" -> "LogEvent.IP_SPOOF")
               case value
               when "IPSpoof" then "LogEvent.IP_SPOOF"
-              when "CSRFViolation" then "LogEvent.CSRF_VIOLATION" 
+              when "CSRFViolation" then "LogEvent.CSRF_VIOLATION"
               else
                 # Default conversion of StudlyCaps to SCREAMING_SNAKE_CASE
                 "LogEvent.#{value.gsub(/([a-z])([A-Z])/, '\1_\2').upcase}"
               end
             end
           end
-          
+
           # Output all fields with types
           log_info[:fields].each do |field_name, field_info|
             type_str = typescript_type_for(field_info)
@@ -189,7 +189,7 @@ def generate_typescript(data)
         ts_content << log_types.join("\n")
         ts_content << ";"
         ts_content << ""
-        
+
         # Add event arrays for each log type that has an enum_union
         ts_content << "// Event type arrays for log types"
         log_event_arrays.each do |log_type, event_values|
@@ -452,7 +452,6 @@ def typescript_type_for(field_info)
               when "LogEvent" then LogStruct::LogEvent
               when "LogLevel" then LogStruct::LogLevel
               when "Source" then LogStruct::Source
-              else nil
               end
 
               if enum_class