use Taskfiles for tasks

Author: ndbroadbent

AGENTS.md

@@ -2,8 +2,8 @@
 
 ## 🚨 CRITICAL RULES - MUST ALWAYS BE FOLLOWED 🚨
 
-1. **NEVER mark a feature as done until `./scripts/all_check.sh` is passing**
-2. **ALWAYS run `./scripts/all_check.sh` before claiming completion**
+1. **NEVER mark a feature as done until `task all` is passing**
+2. **ALWAYS run `task all` before claiming completion**
 3. **NO EXCEPTIONS to the above rules - features are NOT complete until all checks pass**
 4. **This rule must ALWAYS be followed no matter what**
 
@@ -12,8 +12,8 @@
 ### Core Commands
 
 - Setup: `scripts/setup.sh`
-- Run all checks: `scripts/all_check.sh` (runs typecheck, export, lint, test, etc.)
-- Run all checks with auto-fix: `scripts/all_write.sh`
+- Run all checks: `task all` (runs typecheck, export, lint, test, etc.)
+- Run all checks with auto-fix: `task fix`
 - Interactive console: `scripts/console.rb`
 
 ### Testing Commands

Taskfile.prettier.yml

@@ -0,0 +1,20 @@
+version: '3'
+
+tasks:
+  deps:
+    desc: Install repository tooling dependencies (pnpm)
+    run: once
+    cmds:
+      - pnpm install --frozen-lockfile
+
+  check:
+    desc: Check formatting with Prettier
+    deps: [deps]
+    cmds:
+      - scripts/prettier.sh --check
+
+  write:
+    desc: Format files with Prettier
+    deps: [deps]
+    cmds:
+      - scripts/prettier.sh --write

Taskfile.rails.yml

@@ -0,0 +1,18 @@
+version: '3'
+
+vars:
+  RAILS_VERSION: '{{.RAILS_VERSION | default "7.0.8"}}'
+
+tasks:
+  test:
+    desc: Run Rails integration tests (override with RAILS_VERSION=...)
+    cmds:
+      - cmd: RAILS_VERSION={{.RAILS_VERSION}} ./scripts/rails_tests.sh
+        dir: .
+
+  test:matrix:
+    desc: Run Rails integration tests for supported versions (7.0.8 and 8.0.1)
+    cmds:
+      - task: test
+      - cmd: RAILS_VERSION=8.0.1 ./scripts/rails_tests.sh
+        dir: .

Taskfile.ruby.yml

@@ -0,0 +1,37 @@
+version: '3'
+
+tasks:
+  generate:
+    desc: Generate Sorbet structs and TypeScript artifacts
+    cmds:
+      - bundle exec ruby scripts/generate_structs.rb
+
+  typecheck:
+    desc: Run Sorbet type checking
+    cmds:
+      - scripts/typecheck.sh
+
+  lint:
+    desc: Run RuboCop
+    cmds:
+      - bundle exec ruby scripts/rubocop.rb
+
+  lint:fix:
+    desc: Auto-correct RuboCop offenses
+    cmds:
+      - bundle exec ruby scripts/rubocop.rb -A
+
+  check-generated:
+    desc: Ensure generated Ruby structs are up to date (CI safe)
+    cmds:
+      - scripts/check_generated.sh
+
+  test:
+    desc: Run Ruby unit tests
+    cmds:
+      - bundle exec ruby scripts/test.rb
+
+  coverage:merge:
+    desc: Merge Ruby and Rails coverage reports
+    cmds:
+      - scripts/merge_coverage.sh

Taskfile.site.yml

@@ -0,0 +1,37 @@
+version: '3'
+
+tasks:
+  deps:
+    dir: site
+    desc: Install frontend dependencies (pnpm)
+    run: once
+    cmds:
+      - pnpm install --frozen-lockfile
+
+  typecheck:
+    dir: site
+    desc: Run TypeScript type checking
+    deps: [deps]
+    cmds:
+      - pnpm exec tsc --noEmit
+
+  lint:
+    dir: site
+    desc: Run ESLint
+    deps: [deps]
+    cmds:
+      - npm run lint
+
+  lint:fix:
+    dir: site
+    desc: Run ESLint with auto-fix
+    deps: [deps]
+    cmds:
+      - npm run lint -- --fix
+
+  test:
+    dir: site
+    desc: Run frontend tests
+    deps: [deps]
+    cmds:
+      - npm test

Taskfile.yml

@@ -0,0 +1,67 @@
+version: '3'
+
+includes:
+  ruby: ./Taskfile.ruby.yml
+  site: ./Taskfile.site.yml
+  prettier: ./Taskfile.prettier.yml
+  rails: ./Taskfile.rails.yml
+
+tasks:
+  generate:
+    desc: Regenerate LogStruct Ruby and TypeScript structs
+    cmds:
+      - task: ruby:generate
+
+  typecheck:
+    desc: Run Sorbet and TypeScript type checking
+    cmds:
+      - task: ruby:typecheck
+      - task: site:typecheck
+
+  lint:
+    desc: Run Ruby and frontend linters
+    cmds:
+      - task: ruby:lint
+      - task: prettier:check
+      - task: site:lint
+
+  lint:fix:
+    desc: Auto-fix Ruby and frontend lint issues
+    cmds:
+      - task: ruby:lint:fix
+      - task: prettier:write
+      - task: site:lint:fix
+
+  spellcheck:
+    desc: Run repository spellcheck
+    deps: [prettier:deps]
+    cmds:
+      - scripts/spellcheck.sh
+
+  test:
+    desc: Run Ruby unit tests, Rails integration tests, and merge coverage
+    cmds:
+      - task: ruby:check-generated
+      - task: ruby:test
+      - task: rails:test
+      - task: ruby:coverage:merge
+
+  all:
+    desc: Run the full validation workflow (replaces scripts/all_check.sh)
+    cmds:
+      - task: generate
+      - task: typecheck
+      - task: lint
+      - task: spellcheck
+      - task: site:test
+      - task: test
+
+  fix:
+    desc: Auto-fix lint issues then run the full validation workflow (replaces scripts/all_write.sh)
+    cmds:
+      - task: generate
+      - task: typecheck
+      - task: lint:fix
+      - task: spellcheck
+      - task: site:test
+      - task: test

scripts/all_check.sh

@@ -12,7 +12,7 @@
 keys_path = File.join(site_gen, "log-fields.json")
 
 unless File.exist?(enums_path) && File.exist?(structs_path) && File.exist?(keys_path)
-  abort "Missing generated files in #{site_gen}. Run scripts/all_check.sh first."
+  abort "Missing generated files in #{site_gen}. Run `task generate` first."
 end
 
 enums = JSON.parse(File.read(enums_path))

scripts/all_write.sh

@@ -11,6 +11,17 @@ const compat = new FlatCompat({
 
 const eslintConfig = [
   ...compat.extends('next/core-web-vitals', 'next/typescript'),
+  {
+    rules: {
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+        },
+      ],
+    },
+  },
 ];
 
 export default eslintConfig;