Skip to content

Commit a4d9df3

Browse files
committed
fix(container): remove hadolint ignore directives (root cause)
Commit 9f064c5 added `# hadolint ignore=DL3018,SC2261` to suppress hadolint warnings on apk fuzzy `>=` pins. The new Rule Integrity (post v0.4.0 retro, CLAUDE.md amendment) bans ALL linter suppression directives in any language. Fix root cause. Revert to exact `-rN` pins accepted by both apk and hadolint: - ca-certificates=20260413-r0 - tzdata=2026a-r0 - wget=1.25.0-r1 Trade-off: Alpine revision rotation (-r0 → -r1) breaks future builds; bump manually on Alpine updates. Renovate auto-bump config deferred to v0.5.x. Rotation warning documented above each apk RUN block. Step 10b PRE-PUSH VERIFY (new workflow): - git status: only Dockerfile changed - hadolint Dockerfile: 0 warnings - docker build -t pebblify:test .: success - go vet ./...: clean - golangci-lint run ./...: 0 issues - 4-target cross-compile: PASS Closes #42
1 parent 0ebe91a commit a4d9df3

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

Dockerfile

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,12 @@ ARG TARGETARCH
88
ARG VERSION=dev
99
ARG REVISION=unknown
1010

11-
# hadolint ignore=DL3018,SC2261
12-
RUN apk add --no-cache ca-certificates>=20260413 tzdata>=2026a
11+
# Alpine package pins are exact (including -rN revision). Rotation to a new
12+
# revision will break this build; bump manually on Alpine package updates.
13+
# Automated bumps deferred to v0.5.x (Renovate config).
14+
RUN apk add --no-cache \
15+
ca-certificates=20260413-r0 \
16+
tzdata=2026a-r0
1317

1418
WORKDIR /build
1519

@@ -46,11 +50,13 @@ LABEL org.opencontainers.image.title="Pebblify" \
4650
org.opencontainers.image.created="${CREATED}" \
4751
org.opencontainers.image.base.name="alpine:3.22"
4852

49-
# hadolint ignore=DL3018,SC2261
53+
# Alpine package pins are exact (including -rN revision). Rotation to a new
54+
# revision will break this build; bump manually on Alpine package updates.
55+
# Automated bumps deferred to v0.5.x (Renovate config).
5056
RUN apk add --no-cache \
51-
ca-certificates>=20260413 \
52-
tzdata>=2026a \
53-
wget>=1.25.0 \
57+
ca-certificates=20260413-r0 \
58+
tzdata=2026a-r0 \
59+
wget=1.25.0-r1 \
5460
&& addgroup -g 10000 pebblify \
5561
&& adduser -D -H -u 10000 -G pebblify -s /sbin/nologin pebblify
5662

0 commit comments

Comments
 (0)