test: harden persona contract cleanup

Author: ddx-checkpoint

CHANGELOG.md

@@ -29,7 +29,9 @@ not racing asynchronous network/cache work. Workerprobe integration tests also
 isolate server state before constructing test servers, preventing CI's
 state-pollution guard from seeing worker fixture projects. The D3 graph now
 uses the dedicated solid graph-edge tokens for document edges and arrowheads, so
-the frontend contrast guard passes without relying on stroke opacity.
+the frontend contrast guard passes without relying on stroke opacity. Persona
+contract tests now use retrying temp-directory cleanup for the release-blocking
+CI cleanup race observed in the `persona show` not-found case.
 
 ### Fixed: autonomous provider-connectivity recovery
 

cli/cmd/persona_contract_test.go

@@ -3,7 +3,9 @@ package cmd
 import (
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
+	"time"
 
 	"github.com/DocumentDrivenDX/ddx/internal/ddxroot"
 	"github.com/spf13/cobra"
@@ -51,6 +53,28 @@ persona_bindings: {}
 	))
 }
 
+func personaContractTempDir(t *testing.T) string {
+	t.Helper()
+
+	prefix := strings.NewReplacer("/", "-", " ", "-").Replace(t.Name())
+	dir, err := os.MkdirTemp("", prefix+"-*")
+	require.NoError(t, err)
+
+	t.Cleanup(func() {
+		var removeErr error
+		for attempt := 0; attempt < 5; attempt++ {
+			removeErr = os.RemoveAll(dir)
+			if removeErr == nil {
+				return
+			}
+			time.Sleep(time.Duration(attempt+1) * 25 * time.Millisecond)
+		}
+		require.NoError(t, removeErr)
+	})
+
+	return dir
+}
+
 // Contract validation tests verify that persona CLI commands conform to their API contracts
 // as defined in the CLI persona contract
 
@@ -359,7 +383,7 @@ func TestPersonaShowCommand_Contract(t *testing.T) {
 			description: "Exit code 0: Persona found and displayed",
 			args:        []string{"persona", "show", "test-reviewer"},
 			setup: func(t *testing.T) string {
-				testWorkDir := t.TempDir()
+				testWorkDir := personaContractTempDir(t)
 
 				homeDir := t.TempDir()
 				t.Setenv("HOME", homeDir)
@@ -410,7 +434,7 @@ You are an experienced code reviewer who enforces high standards.
 			description: "Exit code 6: Persona not found",
 			args:        []string{"persona", "show", "nonexistent-persona"},
 			setup: func(t *testing.T) string {
-				testWorkDir := t.TempDir()
+				testWorkDir := personaContractTempDir(t)
 
 				homeDir := t.TempDir()
 				t.Setenv("HOME", homeDir)