Merge remote-tracking branch 'origin/main'

Author: easel

README.md

@@ -61,6 +61,7 @@ dun check --changed
 dun list
 dun explain <check-id>
 dun respond --id <check-id> --response -
+dun doctor
 ```
 
 ## Configuration

cmd/dun/doctor.go

@@ -0,0 +1,23 @@
+package main
+
+import (
+	"fmt"
+	"io"
+
+	"github.com/easel/dun/internal/dun"
+)
+
+func runDoctor(args []string, stdout io.Writer, stderr io.Writer) int {
+	if len(args) > 0 {
+		fmt.Fprintln(stderr, "usage: dun doctor")
+		return dun.ExitUsageError
+	}
+	root := resolveRoot(".")
+	report, err := dun.RunDoctor(root)
+	fmt.Fprint(stdout, dun.FormatDoctorReport(report))
+	if err != nil {
+		fmt.Fprintf(stderr, "dun doctor failed: %v\n", err)
+		return dun.ExitRuntimeError
+	}
+	return dun.ExitSuccess
+}

cmd/dun/harnesses.go

@@ -0,0 +1,91 @@
+package main
+
+import (
+	"sort"
+	"strings"
+
+	"github.com/easel/dun/internal/dun"
+)
+
+var defaultQuorumHarnesses = []string{"codex", "claude", "gemini"}
+var harnessPreferenceOrder = []string{"codex", "claude", "gemini", "opencode"}
+
+func resolveHarnessesForQuorum(explicit string) []string {
+	if strings.TrimSpace(explicit) != "" {
+		return parseHarnessCSV(explicit)
+	}
+	if cached := cachedHarnesses(); len(cached) > 0 {
+		return cached
+	}
+	return append([]string{}, defaultQuorumHarnesses...)
+}
+
+func resolveHarnessesForReview(explicit string) []string {
+	return resolveHarnessesForQuorum(explicit)
+}
+
+func parseHarnessCSV(value string) []string {
+	parts := strings.Split(value, ",")
+	out := make([]string, 0, len(parts))
+	for _, part := range parts {
+		trimmed := strings.TrimSpace(part)
+		if trimmed == "" {
+			continue
+		}
+		out = append(out, trimmed)
+	}
+	return out
+}
+
+func cachedHarnesses() []string {
+	cache, err := dun.LoadHarnessCache()
+	if err != nil {
+		return nil
+	}
+	available := cache.AvailableHarnesses()
+	if len(available) == 0 {
+		return nil
+	}
+	filtered := filterKnownHarnesses(available)
+	if len(filtered) == 0 {
+		return nil
+	}
+	return orderHarnesses(filtered)
+}
+
+func filterKnownHarnesses(names []string) []string {
+	var out []string
+	for _, name := range names {
+		if name == "mock" {
+			continue
+		}
+		if !dun.DefaultRegistry.Has(name) {
+			continue
+		}
+		out = append(out, name)
+	}
+	return out
+}
+
+func orderHarnesses(names []string) []string {
+	seen := make(map[string]bool, len(names))
+	for _, name := range names {
+		seen[name] = true
+	}
+	var ordered []string
+	for _, name := range harnessPreferenceOrder {
+		if seen[name] {
+			ordered = append(ordered, name)
+			delete(seen, name)
+		}
+	}
+	if len(seen) == 0 {
+		return ordered
+	}
+	var rest []string
+	for name := range seen {
+		rest = append(rest, name)
+	}
+	sort.Strings(rest)
+	return append(ordered, rest...)
+}

cmd/dun/loop_cache_test.go

@@ -0,0 +1,47 @@
+package main
+
+import (
+	"bytes"
+	"testing"
+	"time"
+
+	"github.com/easel/dun/internal/dun"
+)
+
+func TestRunLoopQuorumUsesCachedHarnesses(t *testing.T) {
+	home := t.TempDir()
+	t.Setenv("HOME", home)
+
+	cache := dun.HarnessCache{
+		LastCheck: time.Now(),
+		Harnesses: []dun.HarnessStatus{{Name: "codex", Command: "codex", Available: true}},
+	}
+	if err := cache.Save(); err != nil {
+		t.Fatalf("save cache: %v", err)
+	}
+
+	root := setupEmptyRepo(t)
+	origCheck := checkRepo
+	checkRepo = func(_ string, _ dun.Options) (dun.Result, error) {
+		return dun.Result{Checks: []dun.CheckResult{{ID: "fail-check", Status: "fail", Signal: "fail"}}}, nil
+	}
+	t.Cleanup(func() { checkRepo = origCheck })
+
+	origHarness := callHarnessFn
+	var gotHarness string
+	callHarnessFn = func(harness, _ string, _ string) (string, error) {
+		gotHarness = harness
+		return "EXIT_SIGNAL: true", nil
+	}
+	t.Cleanup(func() { callHarnessFn = origHarness })
+
+	var stdout bytes.Buffer
+	var stderr bytes.Buffer
+	code := runInDirWithWriters(t, root, []string{"loop", "--max-iterations", "1", "--quorum", "any"}, &stdout, &stderr)
+	if code != dun.ExitSuccess {
+		t.Fatalf("expected success, got %d: %s", code, stderr.String())
+	}
+	if gotHarness != "codex" {
+		t.Fatalf("expected cached harness codex, got %q", gotHarness)
+	}
+}

cmd/dun/main.go

@@ -60,6 +60,8 @@ func run(args []string, stdout io.Writer, stderr io.Writer) int {
 		return runRespond(args[1:], stdout, stderr)
 	case "review":
 		return runReview(args[1:], stdout, stderr)
+	case "doctor":
+		return runDoctor(args[1:], stdout, stderr)
 	case "stamp":
 		return runStamp(args[1:], stdout, stderr)
 	case "install":
@@ -88,6 +90,7 @@ COMMANDS:
   explain    Show details for a specific check
   respond    Process agent response for a check
   review     Run multi-agent review with synthesis
+  doctor     Diagnose harness and helper availability
   stamp      Update doc review stamps
   install    Install dun config and agent documentation
   loop       Run autonomous loop with an agent harness
@@ -103,7 +106,7 @@ REVIEW MODE:
   Options:
     --config     Config file path (default .dun/config.yaml; also loads user config)
     --principles  Path to principles document (default docs/helix/01-frame/principles.md)
-    --harnesses   Comma-separated list of review harnesses (default: codex,claude,gemini)
+    --harnesses   Comma-separated list of review harnesses (default: cached or codex,claude,gemini)
     --synth-harness Harness to synthesize final review (default: first harness)
     --model       Model override for selected harness(es)
     --models      Per-harness model overrides (e.g., codex:o3,claude:sonnet)
@@ -142,7 +145,7 @@ LOOP MODE:
 
   Quorum Options (multi-agent consensus):
     --quorum      Strategy: any, majority, unanimous, or number (e.g., 2)
-    --harnesses   Comma-separated list of harnesses (e.g., codex,claude,gemini,opencode)
+    --harnesses   Comma-separated list of harnesses (default: cached or codex,claude,gemini)
     --cost-optimized   Run harnesses sequentially to minimize cost
     --escalate    Pause for human review on conflict
     --prefer      Preferred harness on conflict (e.g., codex)
@@ -181,6 +184,11 @@ STAMP:
   Options:
     --all        Stamp all docs with dun frontmatter
 
+DOCTOR:
+  dun doctor
+
+  Runs comprehensive environment checks and updates the harness cache.
+
 EXIT CODES:
   0  Success / all checks pass
   1  Check failed
@@ -570,7 +578,8 @@ func runLoop(args []string, stdout io.Writer, stderr io.Writer) int {
 	// Parse quorum configuration if specified
 	var quorumCfg dun.QuorumConfig
 	if *quorumFlag != "" || *harnessesFlag != "" {
-		quorumCfg, err = dun.ParseQuorumFlags(*quorumFlag, *harnessesFlag, *costMode, *escalate, *prefer)
+		resolvedHarnesses := resolveHarnessesForQuorum(*harnessesFlag)
+		quorumCfg, err = dun.ParseQuorumFlags(*quorumFlag, strings.Join(resolvedHarnesses, ","), *costMode, *escalate, *prefer)
 		if err != nil {
 			fmt.Fprintf(stderr, "dun loop failed: quorum config error: %v\n", err)
 			return dun.ExitUsageError

cmd/dun/review.go

@@ -41,7 +41,7 @@ func runReview(args []string, stdout io.Writer, stderr io.Writer) int {
 	fs.SetOutput(stderr)
 	configPath := fs.String("config", explicitConfig, "path to config file (default .dun/config.yaml if present; also loads user config)")
 	principlesPath := fs.String("principles", "docs/helix/01-frame/principles.md", "path to principles document")
-	harnessesFlag := fs.String("harnesses", "codex,claude,gemini", "comma-separated list of review harnesses")
+	harnessesFlag := fs.String("harnesses", "", "comma-separated list of review harnesses")
 	synthHarness := fs.String("synth-harness", "", "harness used to synthesize final review (default: first harness)")
 	model := fs.String("model", opts.AgentModel, "model override for selected harness(es)")
 	models := fs.String("models", "", "per-harness model overrides (e.g., codex:o3,claude:sonnet)")
@@ -77,7 +77,8 @@ func runReview(args []string, stdout io.Writer, stderr io.Writer) int {
 		}
 	}
 
-	reviewCfg, err := dun.ParseQuorumFlags("", *harnessesFlag, false, false, "")
+	resolvedHarnesses := resolveHarnessesForReview(*harnessesFlag)
+	reviewCfg, err := dun.ParseQuorumFlags("", strings.Join(resolvedHarnesses, ","), false, false, "")
 	if err != nil {
 		fmt.Fprintf(stderr, "dun review failed: invalid harness list: %v\n", err)
 		return dun.ExitUsageError

docs/design/contracts/API-001-dun-cli.md

@@ -217,7 +217,7 @@ proceeding (quorum is applied to the iteration prompt, not per-check prompts).
 - `--dry-run` : Print prompt without calling harness
 - `--verbose` : Print prompts sent to harnesses and responses received
 - `--quorum` : Quorum strategy (`any`, `majority`, `unanimous`, or number)
-- `--harnesses` : Comma-separated harness list for quorum (supports `name@persona`)
+- `--harnesses` : Comma-separated harness list for quorum (supports `name@persona`, default cached or `codex,claude,gemini`)
 - `--cost-optimized` : Run harnesses sequentially to minimize cost
 - `--escalate` : Pause for human review on conflict
 - `--prefer` : Preferred harness on conflict
@@ -253,14 +253,33 @@ $ dun loop --verbose
 
 ---
 
+#### Command: doctor
+**Purpose**: Diagnose harness/tool availability and update the harness cache.  
+**Usage**: `$ dun doctor`
+
+**Options**: None
+
+**Input**:
+- Format: File system + environment
+
+**Output**:
+- Format: Human-readable status report
+- Side effects: writes harness cache to `~/.dun/harnesses.json`
+
+**Exit Codes**:
+- `0`: Success
+- `3`: Runtime error (e.g., unable to write cache)
+
+---
+
 #### Command: quorum
 **Purpose**: Run a one-shot multi-agent quorum task and return a selected response.  
 **Usage**: `$ dun quorum [options]`
 
 **Options**:
 - `--task` : Task prompt (string)
 - `--quorum` : Quorum strategy (`any`, `majority`, `unanimous`, or number)
-- `--harnesses` : Comma-separated harness list (supports `name@persona`)
+- `--harnesses` : Comma-separated harness list (supports `name@persona`, default cached or `codex,claude,gemini`)
 - `--cost-optimized` : Run harnesses sequentially to minimize cost
 - `--escalate` : Pause for human review on conflict
 - `--prefer` : Preferred harness on conflict