Fix doc-dag fixtures and staticcheck warnings

easel · easel · commit c0e2de1e2113 · 2026-02-03T15:56:29.000-05:00
diff --git a/.gitignore b/.gitignore
@@ -19,6 +19,9 @@ coverage.html
 !/.dun/
 !/.dun/graphs/
 !/.dun/graphs/**
+!internal/testdata/repos/**/.dun/
+!internal/testdata/repos/**/.dun/graphs/
+!internal/testdata/repos/**/.dun/graphs/**
 /.dun/config.yaml
 test_repo/
 
diff --git a/cmd/dun/main.go b/cmd/dun/main.go
@@ -219,7 +219,7 @@ func runCheck(args []string, stdout io.Writer, stderr io.Writer) int {
 	if err := fs.Parse(args); err != nil {
 		return dun.ExitUsageError
 	}
-	explicitConfig = *configPath
+	_ = *configPath
 
 	opts.AgentMode = "prompt"
 	opts.AutomationMode = *automation
diff --git a/internal/dun/command_check_test.go b/internal/dun/command_check_test.go
@@ -1193,8 +1193,8 @@ func TestExtractIssuesFromJSON_NilData(t *testing.T) {
 	}
 
 	issues := extractIssuesFromJSON(check, nil)
-	if issues != nil && len(issues) != 0 {
-		t.Errorf("expected nil or empty issues for nil data, got %v", issues)
+	if len(issues) != 0 {
+		t.Errorf("expected no issues for nil data, got %v", issues)
 	}
 }
 
diff --git a/internal/dun/engine_test.go b/internal/dun/engine_test.go
@@ -111,7 +111,7 @@ func TestDocDagCascadeStale(t *testing.T) {
 	if !containsStringSlice(check.Prompt.Inputs, "docs/helix/01-frame/prd.md") {
 		t.Fatalf("expected PRD input, got %+v", check.Prompt.Inputs)
 	}
-	if !containsStringSlice(check.Prompt.Inputs, "docs/helix/02-design/adrs/ADR-001.md") {
+	if !containsStringSlice(check.Prompt.Inputs, "docs/helix/02-design/adr/ADR-001.md") {
 		t.Fatalf("expected ADR input, got %+v", check.Prompt.Inputs)
 	}
 	if !containsStringSlice(check.Prompt.Inputs, "internal/feature/feature.go") {
diff --git a/internal/dun/gates_test.go b/internal/dun/gates_test.go
@@ -150,7 +150,7 @@ func TestSplitEvidence(t *testing.T) {
 	if path != "docs/a.md" || anchor != "Section One" {
 		t.Fatalf("unexpected split: %s %s", path, anchor)
 	}
-	path, anchor = splitEvidence("docs/a.md")
+	_, anchor = splitEvidence("docs/a.md")
 	if anchor != "" {
 		t.Fatalf("expected empty anchor")
 	}
diff --git a/internal/dun/harness_test.go b/internal/dun/harness_test.go
@@ -74,16 +74,6 @@ func assertArgsContain(t *testing.T, args []string, required []string) {
 	}
 }
 
-func assertArgsContainSubstring(t *testing.T, args []string, needle string) {
-	t.Helper()
-	for _, arg := range args {
-		if strings.Contains(arg, needle) {
-			return
-		}
-	}
-	t.Fatalf("expected args to contain %q, got %v", needle, args)
-}
-
 func assertFlagValue(t *testing.T, args []string, flag string, value string) {
 	t.Helper()
 	for i, arg := range args {
diff --git a/internal/dun/reconcile_test.go b/internal/dun/reconcile_test.go
@@ -472,7 +472,6 @@ func detectImpactedArtifacts(root string) ([]string, error) {
 	type orderedArtifact struct {
 		path     string
 		priority int
-		subOrder int // For deterministic ordering within category
 	}
 
 	var ordered []orderedArtifact
diff --git a/internal/testdata/repos/doc-dag-cascade/.dun/graphs/helix.yaml b/internal/testdata/repos/doc-dag-cascade/.dun/graphs/helix.yaml
@@ -0,0 +1,15 @@
+required_roots:
+  - helix.prd
+id_map:
+  helix.prd: docs/helix/01-frame/prd.md
+  helix.architecture: docs/helix/02-design/architecture.md
+  helix.test-plan: docs/helix/03-test/test-plan.md
+  F-{id}: docs/helix/01-frame/features/F-{id}-*.md
+  US-{id}: docs/helix/01-frame/user-stories/US-{id}-*.md
+  SD-{id}: docs/helix/02-design/solution-designs/SD-{id}-*.md
+  TP-{id}: docs/helix/03-test/test-plans/TP-{id}-*.md
+  IP-{id}: docs/helix/04-build/implementation-plans/IP-{id}-*.md
+  ADR-{id}: docs/helix/02-design/adr/ADR-{id}.md
+prompt_defaults:
+  helix.prd: prompts/implementation-plan.md
+default_prompt: prompts/implementation-plan.md
diff --git a/internal/testdata/repos/doc-dag-cascade/docs/helix/02-design/adr/ADR-001.md b/internal/testdata/repos/doc-dag-cascade/docs/helix/02-design/adr/ADR-001.md
diff --git a/internal/testdata/repos/doc-dag-missing/.dun/graphs/helix.yaml b/internal/testdata/repos/doc-dag-missing/.dun/graphs/helix.yaml
@@ -0,0 +1,15 @@
+required_roots:
+  - helix.prd
+id_map:
+  helix.prd: docs/helix/01-frame/prd.md
+  helix.architecture: docs/helix/02-design/architecture.md
+  helix.test-plan: docs/helix/03-test/test-plan.md
+  F-{id}: docs/helix/01-frame/features/F-{id}-*.md
+  US-{id}: docs/helix/01-frame/user-stories/US-{id}-*.md
+  SD-{id}: docs/helix/02-design/solution-designs/SD-{id}-*.md
+  TP-{id}: docs/helix/03-test/test-plans/TP-{id}-*.md
+  IP-{id}: docs/helix/04-build/implementation-plans/IP-{id}-*.md
+  ADR-{id}: docs/helix/02-design/adr/ADR-{id}.md
+prompt_defaults:
+  helix.prd: prompts/implementation-plan.md
+default_prompt: prompts/implementation-plan.md
diff --git a/internal/testdata/repos/doc-dag-parking-lot/.dun/graphs/helix.yaml b/internal/testdata/repos/doc-dag-parking-lot/.dun/graphs/helix.yaml
@@ -0,0 +1,15 @@
+required_roots:
+  - helix.prd
+id_map:
+  helix.prd: docs/helix/01-frame/prd.md
+  helix.architecture: docs/helix/02-design/architecture.md
+  helix.test-plan: docs/helix/03-test/test-plan.md
+  F-{id}: docs/helix/01-frame/features/F-{id}-*.md
+  US-{id}: docs/helix/01-frame/user-stories/US-{id}-*.md
+  SD-{id}: docs/helix/02-design/solution-designs/SD-{id}-*.md
+  TP-{id}: docs/helix/03-test/test-plans/TP-{id}-*.md
+  IP-{id}: docs/helix/04-build/implementation-plans/IP-{id}-*.md
+  ADR-{id}: docs/helix/02-design/adr/ADR-{id}.md
+prompt_defaults:
+  helix.prd: prompts/implementation-plan.md
+default_prompt: prompts/implementation-plan.md
diff --git a/internal/update/update_test.go b/internal/update/update_test.go
@@ -3,7 +3,6 @@ package update
 import (
 	"encoding/json"
 	"fmt"
-	"io"
 	"net/http"
 	"net/http/httptest"
 	"os"
@@ -851,15 +850,6 @@ func TestCheckForUpdateDevVersion(t *testing.T) {
 	}
 }
 
-// mockReadCloser for testing body read failures
-type mockReadCloser struct {
-	io.Reader
-}
-
-func (m *mockReadCloser) Close() error {
-	return nil
-}
-
 // Test ApplyUpdateToPath with invalid download path
 func TestApplyUpdateToPathStatError(t *testing.T) {
 	dir := t.TempDir()

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ func runCheck(args []string, stdout io.Writer, stderr io.Writer) int {`
`219`	`219`	`if err := fs.Parse(args); err != nil {`
`220`	`220`	`return dun.ExitUsageError`
`221`	`221`	`}`
`222`		`- explicitConfig = *configPath`
	`222`	`+ _ = *configPath`
`223`	`223`
`224`	`224`	`opts.AgentMode = "prompt"`
`225`	`225`	`opts.AutomationMode = *automation`
Original file line number	Diff line number	Diff line change
`@@ -1193,8 +1193,8 @@ func TestExtractIssuesFromJSON_NilData(t *testing.T) {`
`1193`	`1193`	`}`
`1194`	`1194`
`1195`	`1195`	`issues := extractIssuesFromJSON(check, nil)`
`1196`		`- if issues != nil && len(issues) != 0 {`
`1197`		`- t.Errorf("expected nil or empty issues for nil data, got %v", issues)`
	`1196`	`+ if len(issues) != 0 {`
	`1197`	`+ t.Errorf("expected no issues for nil data, got %v", issues)`
`1198`	`1198`	`}`
`1199`	`1199`	`}`
`1200`	`1200`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ func TestDocDagCascadeStale(t *testing.T) {`
`111`	`111`	`if !containsStringSlice(check.Prompt.Inputs, "docs/helix/01-frame/prd.md") {`
`112`	`112`	`t.Fatalf("expected PRD input, got %+v", check.Prompt.Inputs)`
`113`	`113`	`}`
`114`		`- if !containsStringSlice(check.Prompt.Inputs, "docs/helix/02-design/adrs/ADR-001.md") {`
	`114`	`+ if !containsStringSlice(check.Prompt.Inputs, "docs/helix/02-design/adr/ADR-001.md") {`
`115`	`115`	`t.Fatalf("expected ADR input, got %+v", check.Prompt.Inputs)`
`116`	`116`	`}`
`117`	`117`	`if !containsStringSlice(check.Prompt.Inputs, "internal/feature/feature.go") {`
Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ func TestSplitEvidence(t *testing.T) {`
`150`	`150`	`if path != "docs/a.md" \|\| anchor != "Section One" {`
`151`	`151`	`t.Fatalf("unexpected split: %s %s", path, anchor)`
`152`	`152`	`}`
`153`		`- path, anchor = splitEvidence("docs/a.md")`
	`153`	`+ _, anchor = splitEvidence("docs/a.md")`
`154`	`154`	`if anchor != "" {`
`155`	`155`	`t.Fatalf("expected empty anchor")`
`156`	`156`	`}`
Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,6 @@ func detectImpactedArtifacts(root string) ([]string, error) {`
`472`	`472`	`type orderedArtifact struct {`
`473`	`473`	`path string`
`474`	`474`	`priority int`
`475`		`- subOrder int // For deterministic ordering within category`
`476`	`475`	`}`
`477`	`476`
`478`	`477`	`var ordered []orderedArtifact`