Fix two pre-existing just test failures#21
Merged
Conversation
1. helix-e3c7d0e4 (Epic: per-runtime integration tests) was missing a `<context-digest>` block in its description. The bead is still open, but all 5 child runtime beads (INT-CC/INT-CX/INT-CP/INT-GN/INT-DD) are closed. Add a digest summarizing the epic's governing context (principles, concerns, practices, governing artifacts) so `tests/validate-context-digests.sh` passes. 2. tests/validate-demo-fixtures.sh was checking a SHA-256 coherence between docs/demos/helix-concerns/demo.sh's REVIEW_PROMPT heredoc and an agent-dictionary/<hash>.json fixture. Commit 9e7f734 ("demos(concerns): add drift fixture + README; drop legacy CLI artifacts") deleted demo.sh and the agent-dictionary entirely in favor of a recorded session.jsonl. The test has been failing on main since that commit and its premise (prompt-hash fixture coherence) no longer applies. Remove the test + justfile wiring. `just test` is now fully green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two test failures that have been red on
mainfor weeks, surfaced by the prior PR's cleanup pass and fixed here. Neither was introduced by the prior PR — both pre-existed.1.
tests/validate-context-digests.sh— beadhelix-e3c7d0e4missing context-digestThe Epic bead "per-runtime integration tests (install + skill + one workflow) with screencast capture" is still
status: open(all 5 child runtime beads —INT-CC/INT-CX/INT-CP/INT-GN/INT-DD— are closed). Its description never had a<context-digest>block, so the validator rejected it. Add a digest summarizing the epic's governing context (principles, concerns, practices, governing artifacts).Surgical one-line patch on
.ddx/beads.jsonl— only the target bead's description is modified, all other lines byte-identical.2.
tests/validate-demo-fixtures.sh— premise no longer appliesThe test was a SHA-256 coherence check between:
REVIEW_PROMPTheredoc embedded indocs/demos/helix-concerns/demo.sh, anddocs/demos/helix-concerns/agent-dictionary/<hash>.json.Commit
9e7f734d("demos(concerns): add drift fixture + README; drop legacy CLI artifacts") deleteddemo.shand the agent-dictionary entirely in favor of a recordedsession.jsonl. The check has been failing withFileNotFoundError: docs/demos/helix-concerns/demo.shever since. The premise (prompt-hash ↔ fixture coherence) no longer applies to the new demo shape.Remove the test file and the
justfilewiring (recipe + default-target entry).Test plan
bash tests/validate-context-digests.shexits 0 locallyjust testis fully green locally (8 tests, OK)