Skip to content

Commit a057f97

Browse files
committed
fix(menu): exclude disabled items from link styling
1 parent 4f439db commit a057f97

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

src/menu/menu.module.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,16 @@
6464
}
6565

6666
/* Link menu items without an icon are styled like a text link */
67-
:global(.reactist_menulist) a[role='menuitem']:not(:has(svg)) {
67+
:global(.reactist_menulist) a[role='menuitem']:not(:has(svg)):not([aria-disabled='true']) {
6868
color: var(--reactist-text-link-idle-tint, var(--reactist-actionable-tertiary-idle-tint));
6969
--reactist-content-primary: var(
7070
--reactist-text-link-idle-tint,
7171
var(--reactist-actionable-tertiary-idle-tint)
7272
);
7373
}
7474

75-
:global(.reactist_menulist) a[role='menuitem']:not(:has(svg)):hover,
76-
:global(.reactist_menulist) a[role='menuitem']:not(:has(svg)):focus {
75+
:global(.reactist_menulist) a[role='menuitem']:not(:has(svg)):not([aria-disabled='true']):hover,
76+
:global(.reactist_menulist) a[role='menuitem']:not(:has(svg)):not([aria-disabled='true']):focus {
7777
color: var(--reactist-text-link-hover-tint, var(--reactist-actionable-tertiary-hover-tint));
7878
--reactist-content-primary: var(
7979
--reactist-text-link-hover-tint,

src/menu/menu.stories.jsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,14 @@ export const LinkMenuItemStory = {
226226
>
227227
<Text size="copy">Link without an icon</Text>
228228
</MenuItem>
229+
<MenuItem
230+
disabled
231+
render={
232+
<a href="https://doist.com" target="_blank" rel="noreferrer noopener" />
233+
}
234+
>
235+
<Text size="copy">Disabled link without an icon</Text>
236+
</MenuItem>
229237
</MenuList>
230238
</Menu>
231239
),

0 commit comments

Comments
 (0)