docs: defer the "No Figma link" hint until the entry is prepared#1090
Open
frankieyan wants to merge 1 commit into
Open
docs: defer the "No Figma link" hint until the entry is prepared#1090frankieyan wants to merge 1 commit into
frankieyan wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
doistbot
reviewed
Jun 30, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR fixes the "No Figma link" badge flash on fresh page loads by gating the badge on Storybook's prepared flag, and updates the plop template to re-export FIGMA_NOT_NEEDED.
Few things worth tightening:
- Exporting
FIGMA_NOT_NEEDEDfrom the./figmabarrel pulls a preview-side constant through an entrypoint that already re-exportsFigmaTool, which depends on Storybook's manager API. Consider keeping story/preview consumers on a preview-safe path like./constantsor a dedicated preview export instead of widening this barrel.
9d606bb to
a89c639
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This follow up fix to #1076 and #1080 eliminates a flash of the "No Figma link" badge on stories/docs pages off of a fresh page load. It does so by leveraging Storybook's
getCurrentStoryData().preparedvalue off of its ContextTest plan
Button) and reloadAvatardocs) and reloadfigmaparam (e.g.Box) and reloadFIGMA_NOT_NEEDEDstory (e.g.KeyCapturer) and reloadDemo
First load of a linked story (e.g.
Button):Screen.Recording.2026-06-29.at.7.40.53.PM.mov
Screen.Recording.2026-06-29.at.7.46.46.PM.mov
PR Checklist