fix: respect quiz format when selecting questions

Author: bitfalt

data/quiz-bank.json

@@ -714,7 +714,7 @@
         "hint": "Think of it as a digital ID badge that's been stamped by the server."
       },
       {
-        "belt": "purple",
+        "belt": "brown",
         "format": "free_response",
         "question": "Explain why you should never store passwords in plain text. What is 'hashing' and why is it preferred?",
         "expected_understanding": "Hashing is a one-way function that converts passwords into fixed-length strings. You can't reverse a hash back to the password. When a user logs in, you hash their input and compare hashes. If the database is breached, attackers see hashes, not passwords. Bcrypt adds 'salt' for extra security.",
@@ -885,7 +885,7 @@
         "hint": "Think of an assembly line where each station checks something before passing it along."
       },
       {
-        "belt": "purple",
+        "belt": "brown",
         "format": "free_response",
         "question": "Explain the difference between Continuous Delivery and Continuous Deployment. Why might a team choose one over the other?",
         "expected_understanding": "Continuous Delivery means code is always ready to deploy but requires manual approval for production. Continuous Deployment means every change that passes tests is automatically deployed. Teams handling sensitive data (banking, healthcare) may prefer Delivery for the manual gate, while fast-moving startups may prefer full Deployment.",
@@ -920,15 +920,15 @@
         "hint": "Think of them as 'recipes' that experienced developers have already figured out."
       },
       {
-        "belt": "purple",
+        "belt": "brown",
         "question": "What is the Observer pattern and where might you see it in everyday web development?",
         "options": ["A pattern for watching files for changes", "A pattern where objects subscribe to events and get notified when something changes", "A pattern for monitoring server performance"],
         "correct": 1,
         "explanation": "The Observer pattern lets objects 'subscribe' to events and react when they happen. You use it constantly in web dev: addEventListener in the DOM, React's state/re-render system, Redux subscriptions, and WebSocket message handlers are all variations of Observer.",
         "hint": "Think about event listeners and how multiple parts of your app react to changes."
       },
       {
-        "belt": "purple",
+        "belt": "brown",
         "format": "free_response",
         "question": "Explain the Singleton pattern. What problem does it solve, and what are its potential drawbacks?",
         "expected_understanding": "Singleton ensures a class has only one instance (like a database connection pool or config manager). It solves the problem of accidental duplicate instances of shared resources. Drawbacks: it's essentially a global variable (hard to test, tight coupling), can hide dependencies, and makes parallel testing difficult.",
@@ -945,15 +945,15 @@
         "hint": "Think 'scale up' (bigger) versus 'scale out' (more)."
       },
       {
-        "belt": "purple",
+        "belt": "brown",
         "question": "What is a CDN and how does it improve scalability?",
         "options": ["A type of database", "A network of servers worldwide that caches content close to users", "A programming framework"],
         "correct": 1,
         "explanation": "A CDN (Content Delivery Network) copies your static files (images, CSS, JS) to servers around the world. Users get served from the nearest location, reducing load time. It also takes traffic load off your origin server, improving scalability.",
         "hint": "It's about putting copies of your content closer to where your users are."
       },
       {
-        "belt": "purple",
+        "belt": "brown",
         "format": "free_response",
         "question": "Explain what 'caching' means in web development and describe two different levels where caching can occur.",
         "expected_understanding": "Caching stores frequently requested data in a faster location to avoid recomputing or refetching it. Browser cache (stores assets locally), CDN cache (stores content at edge servers), server-side cache like Redis (stores database query results in memory), and database query cache are common levels. Each level trades freshness for speed.",

scripts/quiz-selector.sh

@@ -22,6 +22,30 @@ QUIZ_BANK="$PLUGIN_ROOT/data/quiz-bank.json"
 # Default output if we can't determine anything
 DEFAULT_OUTPUT='{"mode":"dynamic","concept":null,"reason":"No profile data available","static_question":null,"belt":"white","quiz_format":"multiple_choice"}'
 
+select_static_question() {
+  local concept="$1"
+
+  jq -c \
+    --arg concept "$concept" \
+    --arg belt "$BELT" \
+    --arg format "$QUIZ_FORMAT" '
+      def rank($value):
+        if $value == "white" then 0
+        elif $value == "yellow" then 1
+        elif $value == "orange" then 2
+        elif $value == "green" then 3
+        elif $value == "blue" then 4
+        elif $value == "brown" then 5
+        elif $value == "black" then 6
+        else -1
+        end;
+      (.quizzes[$concept] // []) as $questions |
+      (($questions | map(select(rank(.belt) >= 0 and rank(.belt) <= rank($belt) and ((.format // "multiple_choice") == $format))) | first) //
+       ($questions | map(select(rank(.belt) >= 0 and rank(.belt) <= rank($belt))) | first) //
+       null)
+    ' "$QUIZ_BANK"
+}
+
 if ! command -v jq &> /dev/null; then
   echo "$DEFAULT_OUTPUT"
   exit 0
@@ -114,11 +138,7 @@ fi
 
 # If spaced repetition found a concept, check for a static question
 if [ -n "$SPACED_REP_CONCEPT" ] && [ -f "$QUIZ_BANK" ]; then
-  STATIC_Q=$(jq -c --arg concept "$SPACED_REP_CONCEPT" --arg belt "$BELT" '
-    .quizzes[$concept] // [] |
-    map(select(.belt == $belt or .belt == "white")) |
-    first // null
-  ' "$QUIZ_BANK")
+  STATIC_Q=$(select_static_question "$SPACED_REP_CONCEPT")
 
   if [ "$STATIC_Q" != "null" ] && [ -n "$STATIC_Q" ]; then
     echo "{\"mode\":\"spaced_repetition\",\"concept\":\"$SPACED_REP_CONCEPT\",\"reason\":\"$SPACED_REP_REASON\",\"static_question\":$STATIC_Q,\"belt\":\"$BELT\",\"quiz_format\":\"$QUIZ_FORMAT\"}"
@@ -143,11 +163,7 @@ if [ "$SESSION_CONCEPTS" != "[]" ]; then
 fi
 
 if [ -n "$UNQUIZZED_CONCEPT" ] && [ -f "$QUIZ_BANK" ]; then
-  STATIC_Q=$(jq -c --arg concept "$UNQUIZZED_CONCEPT" --arg belt "$BELT" '
-    .quizzes[$concept] // [] |
-    map(select(.belt == $belt or .belt == "white")) |
-    first // null
-  ' "$QUIZ_BANK")
+  STATIC_Q=$(select_static_question "$UNQUIZZED_CONCEPT")
 
   if [ "$STATIC_Q" != "null" ] && [ -n "$STATIC_Q" ]; then
     echo "{\"mode\":\"static\",\"concept\":\"$UNQUIZZED_CONCEPT\",\"reason\":\"New concept from this session — not yet quizzed.\",\"static_question\":$STATIC_Q,\"belt\":\"$BELT\",\"quiz_format\":\"$QUIZ_FORMAT\"}"
@@ -170,11 +186,7 @@ if [ "$CONCEPTS_SEEN" != "[]" ]; then
 fi
 
 if [ -n "$LEAST_QUIZZED" ] && [ "$LEAST_QUIZZED" != "null" ] && [ -f "$QUIZ_BANK" ]; then
-  STATIC_Q=$(jq -c --arg concept "$LEAST_QUIZZED" --arg belt "$BELT" '
-    .quizzes[$concept] // [] |
-    map(select(.belt == $belt or .belt == "white")) |
-    first // null
-  ' "$QUIZ_BANK")
+  STATIC_Q=$(select_static_question "$LEAST_QUIZZED")
 
   echo "{\"mode\":\"static\",\"concept\":\"$LEAST_QUIZZED\",\"reason\":\"Reinforcing least-practiced concept.\",\"static_question\":$STATIC_Q,\"belt\":\"$BELT\",\"quiz_format\":\"$QUIZ_FORMAT\"}"
   exit 0