Skip to content

Commit f45fff7

Browse files
committed
fix: align CI validation with repo data
1 parent 4efb078 commit f45fff7

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

.github/workflows/validate.yml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
2323
- name: Run shellcheck on lib scripts (if any)
2424
run: |
25-
if ls scripts/lib/*.sh 2>/dev/null | grep -q .; then
25+
if compgen -G "scripts/lib/*.sh" > /dev/null; then
2626
shellcheck scripts/lib/*.sh
2727
else
2828
echo "No scripts/lib/*.sh files found, skipping."
@@ -54,14 +54,14 @@ jobs:
5454
steps:
5555
- uses: actions/checkout@v4
5656

57-
- name: Verify concept-tree.json has .categories array
57+
- name: Verify concept-tree.json has .categories object
5858
run: |
5959
result=$(jq '.categories | type' data/concept-tree.json)
60-
if [ "$result" != '"array"' ]; then
61-
echo "ERROR: concept-tree.json .categories is not an array (got $result)"
60+
if [ "$result" != '"object"' ]; then
61+
echo "ERROR: concept-tree.json .categories is not an object (got $result)"
6262
exit 1
6363
fi
64-
echo "concept-tree.json .categories is a valid array"
64+
echo "concept-tree.json .categories is a valid object"
6565
6666
- name: Verify quiz-bank.json is a non-empty object
6767
run: |
@@ -99,15 +99,13 @@ jobs:
9999

100100
- name: Compare quiz-bank keys vs concept-tree concept keys
101101
run: |
102-
echo "--- Quiz bank top-level keys ---"
103-
quiz_keys=$(jq -r 'keys[]' data/quiz-bank.json | sort)
102+
echo "--- Quiz bank concept IDs ---"
103+
quiz_keys=$(jq -r '.quizzes | keys[]' data/quiz-bank.json | sort)
104104
echo "$quiz_keys"
105105
106106
echo ""
107107
echo "--- Concept tree concept IDs ---"
108-
concept_keys=$(jq -r '.categories[].concepts[].id' data/concept-tree.json 2>/dev/null | sort || \
109-
jq -r '.categories[] | .concepts // [] | .[].id' data/concept-tree.json 2>/dev/null | sort || \
110-
echo "")
108+
concept_keys=$(jq -r '.categories | to_entries[] | .value.concepts | keys[]' data/concept-tree.json | sort)
111109
echo "$concept_keys"
112110
113111
echo ""

0 commit comments

Comments
 (0)