Skip to content

Gotify, Ntfy, Lark, Mattermost, and Custom notification providers silently drop volumeBackup on creation #4084

@mahdirajaee

Description

@mahdirajaee

Description

In packages/server/src/services/notification.ts, several notification creation functions omit the volumeBackup field when inserting into the notifications table, even though their corresponding update functions include it.

Providers missing volumeBackup on creation:

  • createGotifyNotification
  • createNtfyNotification
  • createCustomNotification
  • createLarkNotification
  • createMattermostNotification

Providers that correctly include it (for reference):

  • Slack, Telegram, Discord, Email, Resend, Pushover, Teams

Example comparison:

// Slack create — correct, includes volumeBackup
.values({
    slackId: newSlack.slackId,
    name: input.name,
    appDeploy: input.appDeploy,
    databaseBackup: input.databaseBackup,
    volumeBackup: input.volumeBackup,       // present
    dokployRestart: input.dokployRestart,
})

// Gotify create — missing volumeBackup
.values({
    gotifyId: newGotify.gotifyId,
    name: input.name,
    appDeploy: input.appDeploy,
    databaseBackup: input.databaseBackup,
    // volumeBackup NOT here
    dokployRestart: input.dokployRestart,
})

Impact

Users who set up Gotify/Ntfy/Custom/Lark/Mattermost notifications and enable "Volume Backup" events will not receive volume backup notifications. The setting is silently discarded on creation, defaulting to false in the database. The workaround is to edit the notification after creation, which is confusing.

Fix

Add volumeBackup: input.volumeBackup to the insert values in all 5 affected creation functions. Copy-paste fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions