-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Preview Deployment limit check blocks updating existing previews #4074
Copy link
Copy link
Open
Labels
Description
To Reproduce
- Configure an application with preview deployment limit set to 3
- Open 3 PRs that trigger preview deployments
- Push a commit to one of the open PRs
- The preview does not rebuild, the webhook delivery shows 200 in Github, but no build is queued
- Deleting an old preview deployment to get back under the limit restores rebuild behaviour
Current vs. Expected behavior
Expected
Pushing a commit to a PR with an existing preview deployment should rebuild that preview. The preview limit should only prevent new previews from being created.
Actual
The limit check in the webhook handler runs early & silently drops the update event, leaving the preview build stale
Provide environment information
Operating System: Ubuntu 24.04 LTS
Arch: amd64
Dokploy version: 0.28.7
What applications/services are you trying to deploy?
- Multiple React apps with GitHub App integration and label-based preview deploymentsWhich area(s) are affected? (Select all that apply)
Application
Are you deploying the applications where Dokploy is installed or on a remote server?
Same server where Dokploy is installed
Additional context
Secondary issues in the same check when researching the root cause
- Preview limit defaults to 0 instead of the db schema default of 3
- Limit comparison allows one extra preview beyond the limit
I've created a PR in my fork to show the fix, but I have yet to test this on my server so refrained from submitting upstream
Will you send a PR to fix it?
Maybe, need help
Reactions are currently unavailable