-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix: extractImageTag misidentifies registry port as image tag #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mahdirajaee
wants to merge
64
commits into
Dokploy:canary
Choose a base branch
from
mahdirajaee:fix/extract-image-tag
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
7984497
Merge pull request #1785 from Dokploy/canary
Siumauricio 19a525f
Merge pull request #1824 from Dokploy/canary
Siumauricio 7be1084
Merge pull request #1828 from Dokploy/canary
Siumauricio 5d5d95b
Merge pull request #1836 from Dokploy/canary
Siumauricio f337dd7
Merge pull request #1847 from Dokploy/canary
Siumauricio d779428
Merge pull request #1871 from Dokploy/canary
Siumauricio fa91a74
Merge pull request #1911 from Dokploy/canary
Siumauricio d9ffe51
Merge pull request #1920 from Dokploy/canary
Siumauricio d603654
Merge pull request #1965 from Dokploy/canary
Siumauricio 6676a86
Merge pull request #2061 from Dokploy/canary
Siumauricio 9b7abfb
Merge pull request #2063 from Dokploy/canary
Siumauricio 65f0919
Merge pull request #2068 from Dokploy/canary
Siumauricio 10d17de
Merge pull request #2070 from Dokploy/canary
Siumauricio 4cbc91d
Merge pull request #2091 from Dokploy/canary
Siumauricio 274f380
Merge pull request #2103 from Dokploy/canary
Siumauricio 335a16b
Merge pull request #2114 from Dokploy/canary
Siumauricio b91067d
Merge pull request #2126 from Dokploy/canary
Siumauricio 3b138f8
Merge pull request #2143 from Dokploy/canary
Siumauricio 85d48ab
Merge pull request #2183 from Dokploy/canary
Siumauricio 6c4efa4
Merge pull request #2191 from Dokploy/canary
Siumauricio b615d04
Merge pull request #2193 from Dokploy/canary
Siumauricio f9b0589
Merge pull request #2219 from Dokploy/canary
Siumauricio 13e20e9
Merge pull request #2253 from Dokploy/canary
Siumauricio 8b7d9c0
Merge pull request #2303 from Dokploy/canary
Siumauricio 74caf14
Merge pull request #2323 from Dokploy/canary
Siumauricio fa3cdf1
Merge pull request #2324 from Dokploy/canary
Siumauricio fd267a6
Merge pull request #2354 from Dokploy/canary
Siumauricio 222e487
Merge pull request #2360 from Dokploy/canary
Siumauricio 5a46b87
Merge pull request #2390 from Dokploy/canary
Siumauricio d6050ce
Merge pull request #2408 from Dokploy/canary
Siumauricio ac8960e
Merge pull request #2483 from Dokploy/canary
Siumauricio 976932f
Merge pull request #2557 from Dokploy/canary
Siumauricio ea805c1
Merge pull request #2612 from Dokploy/canary
Siumauricio b15ede8
Merge pull request #2658 from Dokploy/canary
Siumauricio 76af74d
Merge pull request #2721 from Dokploy/canary
Siumauricio 67d3e92
Merge pull request #2765 from Dokploy/canary
Siumauricio b45e7e4
Merge pull request #2901 from Dokploy/canary
Siumauricio f0ea1c8
Merge pull request #3043 from Dokploy/canary
Siumauricio 40de13e
Merge pull request #3055 from Dokploy/canary
Siumauricio d1b639a
Merge pull request #3063 from Dokploy/canary
Siumauricio 4832fd9
Merge pull request #3072 from Dokploy/canary
Siumauricio 1c2307b
Merge pull request #3114 from Dokploy/canary
Siumauricio 1352b85
Merge pull request #3166 from Dokploy/canary
Siumauricio 5cd7de8
Merge pull request #3211 from Dokploy/canary
Siumauricio 42c2076
Merge pull request #3254 from Dokploy/canary
Siumauricio 304454b
Merge pull request #3312 from Dokploy/canary
Siumauricio 1034c79
Merge pull request #3442 from Dokploy/canary
Siumauricio a177d34
Merge pull request #3456 from Dokploy/canary
Siumauricio 1e57d48
Merge pull request #3499 from Dokploy/canary
Siumauricio 4f57851
Merge pull request #3570 from Dokploy/canary
Siumauricio 413ed9b
Merge pull request #3604 from Dokploy/canary
Siumauricio 2c9ca65
Merge pull request #3668 from Dokploy/canary
Siumauricio 5b6d80e
Merge pull request #3682 from Dokploy/canary
Siumauricio f24f1ad
Merge pull request #3805 from Dokploy/canary
Siumauricio e679a32
Merge pull request #3825 from Dokploy/canary
Siumauricio d4719ec
Merge pull request #3845 from Dokploy/canary
Siumauricio ea8e99d
Merge pull request #3875 from Dokploy/canary
Siumauricio 628f16e
fix: update import statements to include file extensions for consistency
Siumauricio 2362778
Merge pull request #3907 from Dokploy/canary
Siumauricio f3356cf
Merge pull request #3938 from Dokploy/canary
Siumauricio a2d6550
Merge pull request #3965 from Dokploy/canary
Siumauricio de3db08
Merge pull request #4020 from Dokploy/canary
Siumauricio 4d8a2a3
Merge pull request #4029 from Dokploy/canary
Siumauricio 8aa0116
Fix extractImageTag parsing registry port as tag for private registry…
mahdirajaee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR's headline fix case —
myregistry:5000/myapp— is not actually fixed by this code.For
"myregistry:5000/myapp":lastIndexOf(":")→ index 10 (the only colon, aftermyregistry)afterColon→"5000/myapp"/^\d{1,5}$/.test("5000/myapp")→false(the$anchor requires the entire substring to be digits; the/myappsuffix breaks the match)"5000/myapp"— identical to the old behaviourThe regex correctly handles
myregistry:5000(bare registry with port, no image path) but misses theregistry:port/imagepathpattern, which is the dominant real-world form.A minimal fix is to also accept a digit sequence followed by a
/:With this regex
"5000/myapp"matches^\d{1,5}\/and returns"latest"as expected, while"v2","latest", and"1.0.0"are unaffected.