Skip to content

fix(github): preview limit check should not block updates to existing previews #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixelburg wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

fix(github): preview limit check should not block updates to existing previews #4139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a059e6e
fix(deployments-queue): reset service status to error when deployment…
mixelburg Apr 3, 2026
47c451e
fix(github): preview limit check should not block updates to existing…
mixelburg Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/dokploy/pages/api/deploy/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,17 +471,18 @@ export default async function handler(
if (!hasLabel) continue;
}

const previewLimit = app?.previewLimit || 0;
if (app?.previewDeployments?.length > previewLimit) {
continue;
}
const previewDeploymentResult =
await findPreviewDeploymentByApplicationId(app.applicationId, prId);

let previewDeploymentId =
previewDeploymentResult?.previewDeploymentId || "";

if (!previewDeploymentResult && shouldCreateDeployment) {
// Only enforce the limit for new previews, not updates to existing ones
const previewLimit = app?.previewLimit ?? 3;
if (app?.previewDeployments?.length >= previewLimit) {
continue;
}
const previewDeployment = await createPreviewDeployment({
applicationId: app.applicationId as string,
branch: prBranch,
Expand Down
13 changes: 13 additions & 0 deletions apps/dokploy/server/queues/deployments-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,19 @@ const createDeploymentWorker = () =>
}
} catch (error) {
console.log("Error", error);
if (job.data.applicationType === "application") {
await updateApplicationStatus(job.data.applicationId, "error").catch(
() => {},
);
} else if (job.data.applicationType === "compose") {
await updateCompose(job.data.composeId, {
composeStatus: "error",
}).catch(() => {});
} else if (job.data.applicationType === "application-preview") {
await updatePreviewDeployment(job.data.previewDeploymentId, {
previewStatus: "error",
}).catch(() => {});
}
}
},
{
Expand Down
Loading