fix: add type="button" to TooltipTrigger in form components#4422
Open
mixelburg wants to merge 1 commit into
Open
fix: add type="button" to TooltipTrigger in form components#4422mixelburg wants to merge 1 commit into
mixelburg wants to merge 1 commit into
Conversation
…t accidental submission
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4400.
TooltipTriggerfrom Radix UI renders as a<button>by default. When used inside a<form>without an explicittype="button", clicking the tooltip icon triggers form submission (since button default type is "submit").This fixes the bug where clicking the
?icon next to the Middlewares field in the domain creation form unexpectedly creates a new domain.Applied
type="button"to allTooltipTriggerelements that are inside form components:handle-domain.tsx— the original reported case (Middlewares tooltip)show-resources.tsx— resource limit tooltips in application advanced settingssave-gitlab-provider-compose.tsx,save-github-provider-compose.tsx,save-bitbucket-provider-compose.tsx— provider form tooltips