feat(organization): add built-in viewer role#4437
Open
Rainash48 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1413
What is this PR about?
This PR implements a focused built-in
viewerrole slice from #1413. It adds a read-only role for assigned runtime resources, wires that role through the invite and change-role flows, reserves theviewername from enterprise custom roles, renames the old enterprise viewer preset toauditorto avoid collisions, and blocks viewers from opening admin-only settings routes directly. The existing enterprise bypass behavior remains limited to owner/admin/member so the new viewer role stays truly read-only.Checklist
Before submitting this PR, please make sure that:
canarybranch.pnpm --filter=dokploy run typecheckandpnpm --filter=dokploy run build-server.pnpm --filter=dokploy run build-nextcompiled successfully but later failed during page-data collection because this workspace does not have the expecteddokploy-postgres/dokploy-redisservices available (ENOTFOUND), so I could not complete end-to-end runtime verification here. I also added focused permission tests for the new viewer behavior, but the current Vitest setup in this checkout fails before running them because deep imports like@dokploy/server/services/permissionare not exported to the test resolver.Issues related (if applicable)
Related to #1413
Screenshots (if applicable)
N/A for this permission/backend slice. If maintainers want it, I can follow up with a short demo video once I can run the full local stack.