fix: open deployments tab when opening a service from the deployments list#4582
Closed
TpmyCT wants to merge 1 commit into
Closed
fix: open deployments tab when opening a service from the deployments list#4582TpmyCT wants to merge 1 commit into
TpmyCT wants to merge 1 commit into
Conversation
… list The Open action in the centralized deployments list navigated to the service's General tab instead of its Deployments tab. Append `?tab=deployments` to the generated link so it deep-links straight to the Deployments tab, matching the redirect the app already performs after a deploy.
TpmyCT
force-pushed
the
fix/open-deployments-tab
branch
from
0795329 to
c53b13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
In the centralized Deployments list (
/dashboard/deployments), the Open action on each row navigated to the related application/compose page but landed on its General tab — forcing you to manually click into the Deployments tab to reach the deployment you came from. This appends?tab=deploymentsto the generated link so Open opens the Deployments tab directly.Tested locally: Open now lands on the Deployments tab for both applications and compose services. It uses the same
?tab=deploymentsdeep-link the app already applies after a deploy (application/general/show.tsx,compose/general/actions.tsx), so the behavior is consistent with the rest of the app.Checklist
canarybranch.Screenshots (if applicable)
Before: Open on a deployment row landed on the service's General tab.
After: Open lands directly on the Deployments tab.