fix: prevent database backups from running the dump twice#4586
Open
ravindu0823 wants to merge 1 commit into
Open
fix: prevent database backups from running the dump twice#4586ravindu0823 wants to merge 1 commit into
ravindu0823 wants to merge 1 commit into
Conversation
getBackupCommand executed the dump command once to /dev/null as a "validation" pass and then a second time piped to rclone. This doubled the load on the database and, on busy databases, risked an inconsistent backup between the two runs. Stream the dump straight to S3 in a single pass and rely on `set -o pipefail` so a dump failure (not just an rclone failure) still aborts the upload and reports an error. Affects all database types that share this command builder (postgres, mysql, mariadb, mongo, libsql, compose). Adds a regression test asserting the dump command appears exactly once and is piped into the upload. Fixes Dokploy#4222 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@-