Skip to content

Add gallerydeals.com custom-domain template#1409

Merged
pawel-kow merged 8 commits into
Domain-Connect:masterfrom
makegravity:add-gallerydeals-custom-domain
Jul 19, 2026
Merged

Add gallerydeals.com custom-domain template#1409
pawel-kow merged 8 commits into
Domain-Connect:masterfrom
makegravity:add-gallerydeals-custom-domain

Conversation

@makegravity

@makegravity makegravity commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a Domain Connect template for GalleryDeals, an online auction platform for auction houses. It lets a customer connect their domain to the platform in one click: it points the site at our host and authenticates the domain for sending auction email.

  • providerId: gallerydeals.com
  • serviceId: custom-domain
  • Records: a site CNAME at the fixed bid subdomain (customer domain to our Azure web app), an asuid.bid domain-ownership-verification TXT (Azure App Service), and three SendGrid automatic-security email CNAMEs: the mail label %sgMailHost% plus two static DKIM selectors (s1._domainkey / s2._domainkey) that share the SendGrid account link %sgLink%.
  • Fixed bid subdomain, no hostRequired: the site records live at the fixed bid label, so the CNAME is never at the zone apex (where a CNAME cannot sit); the template applies at the zone level, so no host parameter is required.
  • Scoped variables: only two remain, %sgMailHost% (SendGrid mail CNAME label) and %sgLink% (SendGrid account link prefix), both documented in variableDescription. The site target, asuid value, and DKIM selectors are all static literals.
  • Signed: syncPubKeyDomain = gallerydeals.com (RS256; public key published at _dcpubkey.gallerydeals.com).

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver - N/A, no logoUrl is set in this template

Checklist of common problems

  • syncPubKeyDomain is set
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content - the only TXT is the asuid.bid ownership-verification record
  • txtConflictMatchingMode - N/A, the single asuid TXT is not a uniqueness-constrained record (not DMARC-style)
  • no variable used as a bare full record value - the asuid TXT value and the site CNAME target are static literals; %sgLink% only appears embedded inside a larger ...sendgrid.net value, never as the whole value
  • no bare variable used as the full host label - site CNAME at bid, TXT at asuid.bid, DKIM at static s1._domainkey / s2._domainkey; the only variable host is %sgMailHost%, the SendGrid mail label, matching the SendGrid email-whitelabel / domain-auth templates
  • no variable used in the host field to create a user-chosen subdomain - %sgMailHost% is the SendGrid-issued mail label, not a user-supplied name
  • %host% does not appear explicitly in any host attribute
  • essential OnApply - N/A, no records the end user should modify or remove (no DMARC)

Online Editor test results

Editor test link(s):

GalleryDeals custom-domain onboarding: points a customer domain at the platform (site CNAME + asuid ownership-verification TXT) and authenticates it for SendGrid email (3 automatic-security CNAMEs). Signed template (syncPubKeyDomain=gallerydeals.com).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Jul 16, 2026
@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

Copy link
Copy Markdown

Linter OK

gallerydeals.com.custom-domain.json

Level Code Note

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot removed the Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. label Jul 16, 2026
…ME can't sit at the zone apex)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added hostRequired hostRequired is set and removed PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. labels Jul 16, 2026
…elative SendGrid) per hostRequired schema

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot removed the Test links missing No test links from Online Editor provided label Jul 17, 2026
Comment thread gallerydeals.com.custom-domain.json Outdated
@github-actions github-actions Bot added the review issues Changes requested from PR review label Jul 17, 2026
@github-actions github-actions Bot added Test links missing No test links from Online Editor provided new review needed New commits arrived to PR after changes requested in the review and removed hostRequired hostRequired is set review issues Changes requested from PR review labels Jul 17, 2026
@github-actions github-actions Bot removed the Test links missing No test links from Online Editor provided label Jul 17, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 2 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@pawel-kow
pawel-kow enabled auto-merge July 19, 2026 17:45
@pawel-kow
pawel-kow added this pull request to the merge queue Jul 19, 2026
Merged via the queue into Domain-Connect:master with commit ea771e0 Jul 19, 2026
8 of 9 checks passed
@github-actions

Copy link
Copy Markdown

Thanks @makegravity for contributing to the template. 🎉

This template has been reviewed and merged by @pawel-kow. 🙌

This template repository and its review process are maintained by independent individuals in their spare time, not as part of a paid role. If you or your company benefit from this protocol and its tools, please show your appreciation by buying a beer for @pawel-kow: https://github.com/sponsors/pawel-kow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new review needed New commits arrived to PR after changes requested in the review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants