You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding 3 templates for Zaroz Cloud (zaroz.cloud), one each for Minecraft, FiveM and Factorio hosting. Each template creates an A record pointing at the server's IP plus an SRV record targeting that same A record via %fqdn%, so the SRV target is always a real resolvable hostname instead of a bare IP. Records are scoped to the applied host/domain via "@" in host/name, no bare %host% anywhere, so users can point either a subdomain or their whole domain apex at their server.
Template file name follows the pattern <providerId>.<serviceId>.json
resource URL provided with logoUrl is actually served by a webserver
Also validated all 3 with the official linter (dc-template-linter -loglevel error -tolerate info -logos -cloudflare), 0 errors, only Cloudflare-specific info notes (syncRedirectDomain/essential not supported by Cloudflare specifically, both still spec-valid and left in for providers that do support them).
Checklist of common problems
syncPubKeyDomain is set
warnPhishing is not set alongside syncPubKeyDomain
syncRedirectDomain is set (redirect_uri is used in the sync flow)
no TXT record contains SPF content (no TXT records in these templates)
txtConflictMatchingMode set where needed (no TXT records)
no bare variable as full record value, except pointsTo/target on the A and SRV records, which is necessary since that's literally where the IP/hostname goes
no bare variable as full host label (host/name are the fixed "@" apex marker, not a variable)
no variable in host field to create a subdomain (host param handles that automatically)
%host% does not appear explicitly in any host attribute
essential set to OnApply where the user may want to modify records independently: not applicable here, these records are core to the service working, so essential: Always is intentional (a manual edit should be treated as a conflict, not silently allowed)
Online Editor test results
Tested subdomain mode (host=mc) for all 3 templates, A+SRV records come out correct in each case. Apex mode (host empty) errors inside the online editor itself with "Invalid data for SRV host: __tcp.@", literal @ left unsubstituted in the editor's own preview, looks like a bug in the editor's apex handling rather than the template (name: "@" for apex is the documented spec behavior, and matches the wording used in this repo's own README example template). Subdomain test links below.
Re: the missing apex tests, this is a known bug in the Online Editor itself, not the templates.
The exact same error (Invalid data for SRV host: __tcp.@) was independently hit and documented in #1349, tried with both "name": "" and "name": "@" there too, same as I did here. And #1091 (the diamondhost.tw Minecraft template already merged in this repo) hit the identical "Test links missing" bot failure for the same reason (no apex test possible) and still got merged.
Subdomain-mode tests (host set) are included below for all 3 templates and produce correct A+SRV output. Happy to provide anything else needed to verify these.
The PR description is missing required elements. Please update it according to the PR template.
Details
OK Type of change: 1/1 checkboxes ticked
OK How Has This Been Tested?: all 3 checkboxes ticked
OK Checklist of common problems: 9/10 checkboxes ticked
OK Online Editor test results: 3 link(s) found
Labels to add: Test links missing
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete
PR description check FAILED:
FAIL Template coverage: zaroz.cloud.factorio-srv.json: missing a test WITHOUT host (or with empty/@)
FAIL Template coverage: zaroz.cloud.fivem-srv.json: missing a test WITHOUT host (or with empty/@)
FAIL Template coverage: zaroz.cloud.minecraft-srv.json: missing a test WITHOUT host (or with empty/@)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
the
Test links missing
Description
Adding 3 templates for Zaroz Cloud (zaroz.cloud), one each for Minecraft, FiveM and Factorio hosting. Each template creates an A record pointing at the server's IP plus an SRV record targeting that same A record via %fqdn%, so the SRV target is always a real resolvable hostname instead of a bare IP. Records are scoped to the applied host/domain via "@" in host/name, no bare %host% anywhere, so users can point either a subdomain or their whole domain apex at their server.
Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverAlso validated all 3 with the official linter (
dc-template-linter -loglevel error -tolerate info -logos -cloudflare), 0 errors, only Cloudflare-specific info notes (syncRedirectDomain/essential not supported by Cloudflare specifically, both still spec-valid and left in for providers that do support them).Checklist of common problems
syncPubKeyDomainis setwarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainis set (redirect_uri is used in the sync flow)txtConflictMatchingModeset where needed (no TXT records)%host%does not appear explicitly in any host attributeessentialset toOnApplywhere the user may want to modify records independently: not applicable here, these records are core to the service working, soessential: Alwaysis intentional (a manual edit should be treated as a conflict, not silently allowed)Online Editor test results
Tested subdomain mode (host=mc) for all 3 templates, A+SRV records come out correct in each case. Apex mode (host empty) errors inside the online editor itself with "Invalid data for SRV host: __tcp.@", literal @ left unsubstituted in the editor's own preview, looks like a bug in the editor's apex handling rather than the template (name: "@" for apex is the documented spec behavior, and matches the wording used in this repo's own README example template). Subdomain test links below.
Editor test link(s):