Skip to content

fix(architecture-decision): add a top H1 for the skill itself#84

Open
specterslient95-lgtm wants to merge 1 commit into
Donchitos:mainfrom
specterslient95-lgtm:fix/architecture-decision-add-h1
Open

fix(architecture-decision): add a top H1 for the skill itself#84
specterslient95-lgtm wants to merge 1 commit into
Donchitos:mainfrom
specterslient95-lgtm:fix/architecture-decision-add-h1

Conversation

@specterslient95-lgtm

Copy link
Copy Markdown

Fixes #83.

The skill had no top-level H1; the first H1 was the placeholder # ADR-[NNNN]: [Title] inside the ADR template the skill emits. Patch adds # architecture-decision: write an Architecture Decision Record (ADR) right after the frontmatter. Template placeholder unchanged.

The skill's first H1 was `# ADR-[NNNN]: [Title]` at line ~234 —
which is the placeholder ADR title inside the template body the
skill writes to disk, NOT a heading for the skill itself. So at the
top of the file there was no rendered title at all; the file went
directly into `## 0. Parse Arguments`.

This patch inserts `# architecture-decision: write an Architecture
Decision Record (ADR)` right after the frontmatter. The downstream
`# ADR-[NNNN]: [Title]` placeholder (which is rendered inside the
ADR template the skill emits) is unchanged.

@Katty53251 Katty53251 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gr46f4

@Katty53251

Copy link
Copy Markdown

Gr46f4

Dxh8rw3y4f30e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

architecture-decision: skill has no top-level H1; the first H1 is the ADR template placeholder

2 participants