Skip to content

Commit 6fbf354

Browse files
BrayanDSOdavid-allison
authored andcommitted
fix: exiting whiteboard crash
calling `requireContext()` after leaving the fragment caused a crash. Fixed by storing the value of whether the system is using gestures navigation instead of retrieving it every time. If the user changes the gestures navigation mode while using the reviewer, the activity and fragment are recreated, so that ends up not being a problem java.lang.IllegalStateException: Fragment ReviewerFragment{a6a61db} (47dfdd3d-a8b4-49be-ad89-2e879c2630b8) not attached to a context. at androidx.fragment.app.Fragment.requireContext(Fragment.java:977) at com.ichi2.anki.ui.windows.reviewer.ReviewerFragment.setupWhiteboard$lambda$1(ReviewerFragment.kt:554) at com.ichi2.anki.ui.windows.reviewer.ReviewerFragment.setupWhiteboard$lambda$1(ReviewerFragment.kt:554)
1 parent d5cfc83 commit 6fbf354

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -545,13 +545,13 @@ class ReviewerFragment :
545545
},
546546
false,
547547
)
548+
val isUsingGesturesNavigation = compat.isUsingSystemGestureNavigation(requireContext())
548549
val doubleBackCallback =
549550
doubleBackPressCallback(
550551
enabled = false,
551552
onFirstBack = { showSnackbar(R.string.back_pressed_once, Snackbar.LENGTH_SHORT) },
552553
shouldReEnable = {
553-
viewModel.whiteboardEnabledFlow.value &&
554-
compat.isUsingSystemGestureNavigation(requireContext())
554+
viewModel.whiteboardEnabledFlow.value && isUsingGesturesNavigation
555555
},
556556
)
557557
requireActivity().onBackPressedDispatcher.addCallback(viewLifecycleOwner, doubleBackCallback)

0 commit comments

Comments
 (0)