refactor: rename clearSubscribers to resetForTesting

we will do additional state clearing work in here for 21102

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/observability/ChangeManager.kt

@@ -139,7 +139,7 @@ object ChangeManager {
     }
 
     @VisibleForTesting(otherwise = VisibleForTesting.NONE)
-    fun clearSubscribers() {
+    fun resetForTesting() {
         subscribers.size.ifNotZero { size -> Timber.d("clearing %d subscribers", size) }
         subscribers.clear()
     }

AnkiDroid/src/test/java/com/ichi2/anki/RobolectricTest.kt

@@ -148,7 +148,7 @@ open class RobolectricTest :
                 // W/ShadowLegacyPath: android.graphics.Path#op() not supported yet.
                 .filter("^(?!(W/ShadowLegacyPath|D/LifecycleMonitor)).*$")
 
-        ChangeManager.clearSubscribers()
+        ChangeManager.resetForTesting()
 
         validateRunWithAnnotationPresent()
 

AnkiDroid/src/test/java/com/ichi2/anki/observability/ChangeManagerTest.kt

@@ -20,7 +20,6 @@ import com.ichi2.testutils.JvmTest
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.equalTo
 import org.hamcrest.Matchers.greaterThan
-import org.junit.After
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
@@ -32,12 +31,6 @@ import kotlin.reflect.jvm.isAccessible
 
 @RunWith(RobolectricTestRunner::class)
 class ChangeManagerExceptionHandlingTest : JvmTest() {
-    @After
-    override fun tearDown() {
-        super.tearDown()
-        ChangeManager.clearSubscribers()
-    }
-
     @Test
     fun `all subscribers notified even if one throws exception`() {
         var firstCalled = false

AnkiDroid/src/test/java/com/ichi2/testutils/JvmTest.kt

@@ -34,7 +34,7 @@ open class JvmTest : InMemoryAnkiTest() {
     @CallSuper
     override fun setUp() {
         super.setUp()
-        ChangeManager.clearSubscribers()
+        ChangeManager.resetForTesting()
     }
 
     override fun setupTestDispatcher(dispatcher: TestDispatcher) {