fix(everything): make everything config uniform, resolve other plugin type/coercion bugs, and qualify HttpClient/ZipFile usages

Author: DotDev262

plugins/7-zip/src/plugin.py

@@ -124,6 +124,25 @@ def apply_config(args, context, request_id):
     changed = False
     to_update = {}
 
+    # Coerce values parsed as string from YAML representation
+    if "CompressionLevel" in desired:
+        try:
+            desired["CompressionLevel"] = int(desired["CompressionLevel"])
+        except (ValueError, TypeError):
+            pass
+    if "ContextMenu" in desired:
+        try:
+            desired["ContextMenu"] = int(desired["ContextMenu"])
+        except (ValueError, TypeError):
+            pass
+    if "EncryptHeaders" in desired:
+        val = desired["EncryptHeaders"]
+        if isinstance(val, str):
+            if val.lower() == "true":
+                desired["EncryptHeaders"] = True
+            elif val.lower() == "false":
+                desired["EncryptHeaders"] = False
+
     for key, val in desired.items():
         # Validate values
         if key == "CompressionLevel":

plugins/chezmoi/src/plugin.py

@@ -1,3 +1,9 @@
+# /// script
+# dependencies = [
+#   "pyyaml",
+# ]
+# ///
+
 import json
 import os
 import shutil

plugins/deno/plugin.yaml

@@ -1,6 +1,7 @@
 name: deno
 description: Deno configuration provider plugin
 version: 1.0.0
+type: python
 main: src/plugin.py
 capabilities:
   - config_provider

plugins/espanso/src/plugin.py

@@ -9,6 +9,12 @@
   - apply:           Deep-merge matches/global_vars into base.yml
 """
 
+# /// script
+# dependencies = [
+#   "pyyaml",
+# ]
+# ///
+
 import json
 import os
 import sys

plugins/everything/src/plugin.py

@@ -31,7 +31,14 @@ def load_config():
 def merge_config(config, settings):
     changed = False
 
+    # Detect if settings are flat (no sub-dictionaries) to keep configuration format uniform
+    has_sections = any(isinstance(v, dict) for v in settings.values())
+    if not has_sections:
+        settings = {"Everything": settings}
+
     for section, values in settings.items():
+        if not isinstance(values, dict):
+            continue
         if not config.has_section(section):
             config.add_section(section)
 

plugins/miniconda/src/plugin.py

@@ -1,3 +1,9 @@
+# /// script
+# dependencies = [
+#   "pyyaml",
+# ]
+# ///
+
 import json
 import os
 import shutil

plugins/starship/src/plugin.py

@@ -115,7 +115,7 @@ def check_installed(args: dict, request_id: str) -> dict:
 
 def apply_config(args: dict, context: dict, request_id: str) -> dict:
     dry_run = context.get("dryRun", False)
-    settings = args
+    settings = args.get("settings", {}) or {}
 
     try:
         config_path = get_config_path()

src/Engine.cs

@@ -435,7 +435,11 @@ await Task.Run(() => Parallel.ForEach(itemsToRemove, uniqueId =>
                 var checkResult = await _pluginRunner.ExecuteAsync(plugin, "check_installed", new { packageId = pluginName }, new { dryRun = dryRun });
                 if (checkResult.Success)
                 {
-                  if (checkResult.Data is bool installedBool)
+                  if (checkResult.Installed.HasValue)
+                  {
+                    isInstalled = checkResult.Installed.Value;
+                  }
+                  else if (checkResult.Data is bool installedBool)
                   {
                     isInstalled = installedBool;
                   }