Fix: Resolve config path, dryRun flag, and empty string bugs#484
Merged
Conversation
github-actions
Bot
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely fixes the configuration handling issues reported in #370.
Changes made:
APPDATApath with a robust cross-platform fallback so WinHome works seamlessly on macOS and Linux.dry_runanddryRunacross all plugin files to ensure the dry-run mode works predictably.merge_settings()logic to explicitly handle and delete keys when an empty string ("") is passed, rather than silently ignoring them.Related Issue
Closes #370
Checklist