Fix thread-unsafe HashSet in Parallel.ForEach cleanup and dry-run guard ordering - #493
Closed
saurabhhhcodes wants to merge 1 commit into
Closed
Fix thread-unsafe HashSet in Parallel.ForEach cleanup and dry-run guard ordering#493saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
Owner
|
Closing this PR per repository guidelines: PRs from non-assignees are not accepted (issues must be assigned before submitting pull requests). Furthermore, confirmedApplied in src/Engine.cs is already a thread-safe ConcurrentDictionary<string, byte> on main using .TryRemove(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: Thread-unsafe
HashSet<string>inParallel.ForEachconfirmedAppliedis a non-thread-safeHashSetbeing modified via.Remove()inside aParallel.ForEachatsrc/Engine.cs:163,175. This causes race conditions including incorrect state tracking. Wrapped remove operations with alock.Bug 2: Dry-run guard ordering in registry cleanup
_registry.Revert(...)was called before the!dryRuncheck atsrc/Engine.cs:160. WhileRevertcurrently respectsdryRuninternally, the ordering violates defense-in-depth — a mutating operation should never precede its dry-run guard. Reordered to check!dryRunfirst and passfalseexplicitly.