Skip to content

Commit 7e2c29e

Browse files
Copilotjosephaw1022
andcommitted
Revert QuoteName security changes - not part of original requirements
Co-authored-by: josephaw1022 <47674962+josephaw1022@users.noreply.github.com>
1 parent 125ae6c commit 7e2c29e

2 files changed

Lines changed: 2 additions & 14 deletions

File tree

src/OperatorTemplate.Operator/Finalizers/V1Alpha1/SQLServerUserFinalizer.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,11 @@ private async Task DeleteUserAsync(string databaseName, string loginName, string
7575
var commandText = $@"
7676
IF EXISTS (SELECT name FROM sys.database_principals WHERE name = @LoginName)
7777
BEGIN
78-
DROP USER {QuoteName(loginName)};
78+
DROP USER [{loginName}];
7979
END";
8080

8181
using var command = new SqlCommand(commandText, connection);
8282
command.Parameters.AddWithValue("@LoginName", loginName);
8383
await command.ExecuteNonQueryAsync();
8484
}
85-
86-
private static string QuoteName(string name)
87-
{
88-
// Escape any existing square brackets and wrap the name in square brackets
89-
return $"[{name.Replace("]", "]]")}]";
90-
}
9185
}

src/OperatorTemplate.Operator/Finalizers/V1Alpha1/SqlServerLoginFinalizer.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,11 @@ private async Task DeleteLoginAsync(string loginName, string server, string user
7575
var commandText = $@"
7676
IF EXISTS (SELECT name FROM sys.sql_logins WHERE name = @LoginName)
7777
BEGIN
78-
DROP LOGIN {QuoteName(loginName)};
78+
DROP LOGIN [{loginName}];
7979
END";
8080

8181
using var command = new SqlCommand(commandText, connection);
8282
command.Parameters.AddWithValue("@LoginName", loginName);
8383
await command.ExecuteNonQueryAsync();
8484
}
85-
86-
private static string QuoteName(string name)
87-
{
88-
// Escape any existing square brackets and wrap the name in square brackets
89-
return $"[{name.Replace("]", "]]")}]";
90-
}
9185
}

0 commit comments

Comments
 (0)