refactor: Improved code quality based on roslyn suggestions

Author: DoubledDoge

.editorconfig

@@ -186,6 +186,8 @@ dotnet_naming_style.begins_with_i.capitalization = pascal_case
 # Disabled rules
 
 dotnet_diagnostic.CA1720.severity = none
+dotnet_diagnostic.CA1303.severity = none
+dotnet_diagnostic.S3358.severity = none
 
 [*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}]
 indent_size = 2

Directory.Packages.props

@@ -1,11 +1,11 @@
 <Project>
-  <PropertyGroup>
-    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-  </PropertyGroup>
-  <ItemGroup>
-    <PackageVersion Include="Avalonia" Version="11.3.12" />
-    <PackageVersion Include="Microsoft.AspNetCore.Components.Web" Version="9.0.14" />
-    <PackageVersion Include="Microsoft.Maui.Controls" Version="9.0.120" />
-    <PackageVersion Include="SonarAnalyzer.CSharp" Version="10.21.0.135717" />
-  </ItemGroup>
-</Project>
+	<PropertyGroup>
+		<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+	</PropertyGroup>
+	<ItemGroup>
+		<PackageVersion Include="Avalonia" Version="11.3.12" />
+		<PackageVersion Include="Microsoft.AspNetCore.Components.Web" Version="9.0.14" />
+		<PackageVersion Include="Microsoft.Maui.Controls" Version="9.0.120" />
+		<PackageVersion Include="SonarAnalyzer.CSharp" Version="10.21.0.135717" />
+	</ItemGroup>
+</Project>

src/TypeGuard.Console/ConsoleInput.cs

@@ -18,7 +18,7 @@ public class ConsoleInput : IInputProvider
 	/// <param name="cancellationToken">A token to cancel the asynchronous operation.</param>
 	/// <returns>A task representing the asynchronous operation. The task result contains the trimmed input string, or null if no input was provided.</returns>
 	public async Task<string?> GetInputAsync(CancellationToken cancellationToken = default) =>
-		await Task.Run(GetInput, cancellationToken);
+		await Task.Run(GetInput, cancellationToken).ConfigureAwait(false);
 
 	/// <summary>
 	/// Synchronously reads a line of text from the console, trimming any leading or trailing whitespace.

src/TypeGuard.Console/ConsoleOutput.cs

@@ -21,7 +21,7 @@ public class ConsoleOutput : IOutputProvider
 	public async Task DisplayPromptAsync(
 		string message,
 		CancellationToken cancellationToken = default
-	) => await Task.Run(() => DisplayPrompt(message), cancellationToken);
+	) => await Task.Run(() => DisplayPrompt(message), cancellationToken).ConfigureAwait(false);
 
 	/// <summary>
 	/// Asynchronously displays an error message to the console in red and waits for the user to
@@ -37,7 +37,7 @@ public async Task DisplayPromptAsync(
 	public async Task DisplayErrorAsync(
 		string message,
 		CancellationToken cancellationToken = default
-	) => await Task.Run(() => DisplayError(message), cancellationToken);
+	) => await Task.Run(() => DisplayError(message), cancellationToken).ConfigureAwait(false);
 
 	/// <summary>
 	/// Synchronously displays a prompt message to the console, followed by a colon and space.

src/TypeGuard.Core/Builders/BuilderBase.cs

@@ -55,7 +55,7 @@ protected TSelf AddRule(IValidatorRule<T> rule)
 	public async Task<T> GetAsync(CancellationToken cancellationToken = default)
 	{
 		_frozen = true;
-		return await _handler.GetValidInputAsync(cancellationToken);
+		return await _handler.GetValidInputAsync(cancellationToken).ConfigureAwait(false);
 	}
 
 	/// <summary>

src/TypeGuard.Core/Builders/StringInputBuilder.cs

@@ -44,36 +44,25 @@ public StringInputBuilder WithLengthRange(
 		int? minLength = null,
 		int? maxLength = null,
 		string? customMessage = null
-	)
-	{
-		if (minLength is < 0)
-		{
-			throw new ArgumentOutOfRangeException(
+	) =>
+		minLength is < 0
+			? throw new ArgumentOutOfRangeException(
 				nameof(minLength),
 				minLength,
 				"minLength must be greater than or equal to zero."
-			);
-		}
-
-		if (maxLength is < 0)
-		{
-			throw new ArgumentOutOfRangeException(
+			)
+		: maxLength is < 0
+			? throw new ArgumentOutOfRangeException(
 				nameof(maxLength),
 				maxLength,
 				"maxLength must be greater than or equal to zero."
-			);
-		}
-
-		if (minLength.HasValue && maxLength.HasValue && minLength.Value > maxLength.Value)
-		{
-			throw new ArgumentException(
+			)
+		: minLength.HasValue && maxLength.HasValue && minLength.Value > maxLength.Value
+			? throw new ArgumentException(
 				$"minLength ({minLength}) must be less than or equal to maxLength ({maxLength}).",
 				nameof(minLength)
-			);
-		}
-
-		return AddRule(new StringLengthRule(minLength, maxLength, customMessage));
-	}
+			)
+		: AddRule(new StringLengthRule(minLength, maxLength, customMessage));
 
 	/// <summary>
 	/// Adds a rule that ensures the string contains numeric digits.

src/TypeGuard.Core/Handlers/GuidHandler.cs

@@ -24,7 +24,7 @@ protected override bool TryParse(string? input, out Guid value, out string? erro
 			return true;
 		}
 
-		value = default;
+		value = Guid.Empty;
 		errorMessage = "Please enter a valid GUID (e.g., 3f2504e0-4f89-11d3-9a0c-0305e82c3301).";
 		return false;
 	}

src/TypeGuard.Core/Handlers/HandlerBase.cs

@@ -42,27 +42,32 @@ public async Task<T> GetValidInputAsync(CancellationToken cancellationToken = de
 		{
 			cancellationToken.ThrowIfCancellationRequested();
 
-			await _outputProvider.DisplayPromptAsync(_prompt, cancellationToken);
-			string? rawInput = await _inputProvider.GetInputAsync(cancellationToken);
+			await _outputProvider
+				.DisplayPromptAsync(_prompt, cancellationToken)
+				.ConfigureAwait(false);
+			string? rawInput = await _inputProvider
+				.GetInputAsync(cancellationToken)
+				.ConfigureAwait(false);
 
 			if (!TryParse(rawInput, out T? value, out string? parseError))
 			{
-				await _outputProvider.DisplayErrorAsync(parseError!, cancellationToken);
+				await _outputProvider
+					.DisplayErrorAsync(parseError!, cancellationToken)
+					.ConfigureAwait(false);
 				continue;
 			}
 
-			bool allRulesPassed = true;
-			foreach (IValidatorRule<T> rule in _rules.Where(rule => !rule.IsValid(value!)))
-			{
-				await _outputProvider.DisplayErrorAsync(rule.ErrorMessage, cancellationToken);
-				allRulesPassed = false;
-				break;
-			}
+			IValidatorRule<T>? failedRule = _rules.FirstOrDefault(rule => !rule.IsValid(value!));
 
-			if (allRulesPassed)
+			if (failedRule is not null)
 			{
-				return value!;
+				await _outputProvider
+					.DisplayErrorAsync(failedRule.ErrorMessage, cancellationToken)
+					.ConfigureAwait(false);
+				continue;
 			}
+
+			return value!;
 		}
 	}
 

src/TypeGuard.Core/Handlers/TimeSpanHandler.cs

@@ -1,7 +1,9 @@
-using TypeGuard.Core.Interfaces;
+using System.Globalization;
 
 namespace TypeGuard.Core.Handlers;
 
+using Interfaces;
+
 /// <summary>
 /// An input handler that prompts for and validates TimeSpan input.
 /// Accepts various formats including "hh:mm:ss", "d.hh:mm:ss", or total units like "5.5".
@@ -22,16 +24,16 @@ public class TimeSpanHandler(
 	protected override bool TryParse(string? input, out TimeSpan value, out string? errorMessage)
 	{
 		bool success = format is not null
-			? TimeSpan.TryParseExact(input, format, null, out value)
-			: TimeSpan.TryParse(input, out value);
+			? TimeSpan.TryParseExact(input, format, CultureInfo.InvariantCulture, out value)
+			: TimeSpan.TryParse(input, CultureInfo.InvariantCulture, out value);
 
 		if (success)
 		{
 			errorMessage = null;
 			return true;
 		}
 
-		value = default;
+		value = TimeSpan.Zero;
 		errorMessage = format is not null
 			? $"Please enter a valid time span in the format '{format}'."
 			: "Please enter a valid time span (e.g., '1:30:00' or '1.12:00:00').";

src/TypeGuard.Core/Rules/BuildHelper.cs

@@ -0,0 +1,16 @@
+using System.Runtime.CompilerServices;
+
+namespace TypeGuard.Core.Rules;
+
+internal static class BuildHelper<T>
+{
+	internal static HashSet<T> BuildSet(
+		IEnumerable<T> values,
+		[CallerArgumentExpression(nameof(values))] string? paramName = null
+	)
+	{
+		ArgumentNullException.ThrowIfNull(values, paramName);
+		HashSet<T> set = [.. values];
+		return set.Count == 0 ? throw new ArgumentException("Cannot be empty.", paramName) : set;
+	}
+}