Require T: 'static for Store, upgrade to wasmtime_runtime_layer v34.0.0#54
Merged
Conversation
Collaborator
Author
|
The nightly error seems to come from a wasmer regression on nightly, see wasmerio/wasmer#5610 |
|
@juntyr thanks for the CC. I wonder why Wasmtime now requires the I will not re-introduce |
|
I tried my best to avoid adding it to Wasmtime but 🤷. I am but a slave to rustc compiler error messages in the end. The tl;dr; is that this helps avoid a lot of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With bytecodealliance/wasmtime#10760, wasmtime now requires
T: 'staticfor store. While we advocated to not have the bound in wasmi, it now seems like the ship has sailed and we have to adapt.@alexcrichton Since you also tried to avoid a static bound for as long as possible, do you think it makes sense for our abstraction over several WASM runtimes to adopt the bound?
@Robbepop If we go forward here, it means you can bring back the static bound in wasmi as well - thank you for removing it a few versions ago to help our downstream crate, now the momentum is in favour of your original change.
@DouglasDwyer This will require a major release for wasm_runtime_layer (and wasm_component_layer). I've prepared updates for wasmtime_runtime_layer and js_wasm_runtime_layer in this PR, I think for wasmi and wasmer we just wait until their next release.