[Node] add delete workflow in debug view

Author: GuillaumeDSM

packages/node/octobot_node/scheduler/scheduler.py

@@ -242,6 +242,27 @@ async def _get_parent_and_children_automation_workflow_ids(
         )
         return [workflow.workflow_id for workflow in matching_workflows]
 
+    async def _get_user_action_workflow_ids(
+        self,
+        user_id: typing.Optional[str],
+        user_action_ids: list[str],
+        statuses: list[dbos.WorkflowStatusString],
+        load_output: bool = False
+    ) -> list[str]:
+        if not user_action_ids:
+            return []
+        user_action_id_set = set(user_action_ids)
+        matching_workflows = await self._list_workflows(
+            user_id, statuses,
+            [octobot_node.enums.SchedulerQueues.USER_ACTION_QUEUE.value], load_output
+        )
+        matched_workflow_ids: list[str] = []
+        for workflow in matching_workflows:
+            user_action_id = self._user_action_id_from_workflow(workflow, load_output=load_output)
+            if user_action_id is not None and user_action_id in user_action_id_set:
+                matched_workflow_ids.append(workflow.workflow_id)
+        return matched_workflow_ids
+
     async def resolve_active_automation_workflow_ids_for_parent_id(
         self,
         user_id: typing.Optional[str],
@@ -299,17 +320,30 @@ async def cancel_workflows(self, workflow_ids: list[str]) -> list[str]:
         except Exception as e:
             self.logger.exception(e, True, f"Failed to cancel workflows {workflow_ids}: {e}")
             return []
-
-    async def delete_workflows(self, to_delete_workflow_ids: list[str]):
-        self.logger.info(f"Deleting {len(to_delete_workflow_ids)} workflows")
-        merged_to_delete_workflow_ids = await self._get_parent_and_children_automation_workflow_ids(
+    
+    async def _get_workflows_to_delete(self, workflow_ids: list[str]) -> list[str]:
+        automation_workflows = await self._get_parent_and_children_automation_workflow_ids(
             None,
-            to_delete_workflow_ids,
+            workflow_ids,
             [
                 dbos.WorkflowStatusString.SUCCESS, dbos.WorkflowStatusString.ERROR,
                 dbos.WorkflowStatusString.CANCELLED, dbos.WorkflowStatusString.MAX_RECOVERY_ATTEMPTS_EXCEEDED
             ]
         )
+        user_action_workflows = await self._get_user_action_workflow_ids(
+            None,
+            workflow_ids,
+            [
+                dbos.WorkflowStatusString.SUCCESS, dbos.WorkflowStatusString.ERROR,
+                dbos.WorkflowStatusString.CANCELLED, dbos.WorkflowStatusString.MAX_RECOVERY_ATTEMPTS_EXCEEDED
+            ],
+            load_output=True,
+        )
+        return automation_workflows + user_action_workflows
+
+    async def delete_workflows(self, to_delete_workflow_ids: list[str]):
+        self.logger.info(f"Deleting {len(to_delete_workflow_ids)} workflows")
+        merged_to_delete_workflow_ids = await self._get_workflows_to_delete(to_delete_workflow_ids)
         self.logger.info(
             f"Including {len(merged_to_delete_workflow_ids) - len(to_delete_workflow_ids)} associated children workflows to delete"
         )
@@ -547,6 +581,21 @@ def _user_action_list_sort_key(
         workflow_identifier = str(workflow_status.workflow_id or "")
         return (workflow_status.created_at or 0, user_action.id, workflow_identifier)
 
+    def _user_action_id_from_workflow(
+        self,
+        workflow_status: dbos.WorkflowStatus,
+        *,
+        load_output: bool,
+    ) -> typing.Optional[str]:
+        if load_output and workflow_status.output:
+            from_output = self._parse_user_action_from_workflow_output(workflow_status)
+            if from_output is not None:
+                return from_output.id
+        resolved = workflows_util.resolve_user_action_workflow_inputs(workflow_status)
+        if resolved.inputs is not None and resolved.inputs.user_action is not None:
+            return resolved.inputs.user_action.id
+        return resolved.partial_user_action_id
+
     def _parse_user_action_from_workflow_output(
         self,
         workflow_status: dbos.WorkflowStatus,

packages/node/tests/scheduler/test_scheduler.py

@@ -23,6 +23,7 @@
 import octobot_commons.cryptography
 import octobot_protocol.models as protocol_models
 import octobot_node.config
+import octobot_node.enums
 import octobot_node.models
 import octobot_node.scheduler.encryption as encryption
 import octobot_node.scheduler.encryption.task_inputs as task_inputs_encryption
@@ -87,6 +88,52 @@ def _make_scheduler_with_mock_instance() -> tuple[scheduler_module.Scheduler, mo
     return sched, sched.INSTANCE
 
 
+_DELETE_WORKFLOW_STATUSES = [
+    dbos.WorkflowStatusString.SUCCESS,
+    dbos.WorkflowStatusString.ERROR,
+    dbos.WorkflowStatusString.CANCELLED,
+    dbos.WorkflowStatusString.MAX_RECOVERY_ATTEMPTS_EXCEEDED,
+]
+
+
+def _build_user_action_workflow_with_inputs(
+    user_action_id: str,
+    workflow_id: str,
+    user_id: str = "0xw1",
+) -> mock.Mock:
+    user_action = protocol_models.UserAction(id=user_action_id, configuration=None)
+    workflow_inputs = params.UserActionWorkflowInputs(
+        user_id=user_id,
+        user_action=user_action,
+    ).to_dict(include_default_values=False)
+    workflow_status = mock.Mock(spec=dbos.WorkflowStatus)
+    workflow_status.workflow_id = workflow_id
+    workflow_status.input = {"args": [workflow_inputs], "kwargs": {}}
+    workflow_status.output = None
+    return workflow_status
+
+
+def _build_user_action_workflow_with_output(
+    user_action_id: str,
+    workflow_id: str,
+    user_id: str = "0xw1",
+) -> mock.Mock:
+    user_action = protocol_models.UserAction(
+        id=user_action_id,
+        status=protocol_models.UserActionStatus.COMPLETED,
+        configuration=None,
+    )
+    output_payload = params.UserActionWorkflowOutput(
+        user_id=user_id,
+        updated_user_action=user_action,
+    ).to_dict(include_default_values=False)
+    workflow_status = mock.Mock(spec=dbos.WorkflowStatus)
+    workflow_status.workflow_id = workflow_id
+    workflow_status.input = {"args": [], "kwargs": {}}
+    workflow_status.output = output_payload
+    return workflow_status
+
+
 class TestSchedulerGetResults:
 
     @pytest.mark.asyncio
@@ -940,3 +987,82 @@ async def test_terminal_workflow_with_empty_input_returns_minimal_failed_action(
         assert isinstance(inner, protocol_models.AccountActionResult)
         assert inner.error_details is not None
         assert "persist failed" in inner.error_details
+
+
+class TestSchedulerGetUserActionWorkflowIds:
+    @pytest.mark.asyncio
+    async def test_returns_empty_when_user_action_ids_empty(self):
+        sched, mock_instance = _make_scheduler_with_mock_instance()
+        result = await sched._get_user_action_workflow_ids(None, [], _DELETE_WORKFLOW_STATUSES)
+        assert result == []
+        mock_instance.list_workflows_async.assert_not_called()
+
+    @pytest.mark.asyncio
+    async def test_matches_by_parsed_input_user_action_id(self):
+        workflow_status = _build_user_action_workflow_with_inputs("ua-1", "wf-ua-1")
+        sched, mock_instance = _make_scheduler_with_mock_instance()
+        mock_instance.list_workflows_async = mock.AsyncMock(return_value=[workflow_status])
+        result = await sched._get_user_action_workflow_ids(
+            None,
+            ["ua-1"],
+            _DELETE_WORKFLOW_STATUSES,
+        )
+        assert result == ["wf-ua-1"]
+
+    @pytest.mark.asyncio
+    async def test_skips_workflows_with_unrelated_user_action_id(self):
+        workflow_first = _build_user_action_workflow_with_inputs("ua-1", "wf-1")
+        workflow_second = _build_user_action_workflow_with_inputs("ua-2", "wf-2")
+        sched, mock_instance = _make_scheduler_with_mock_instance()
+        mock_instance.list_workflows_async = mock.AsyncMock(
+            return_value=[workflow_first, workflow_second],
+        )
+        result = await sched._get_user_action_workflow_ids(
+            None,
+            ["ua-1"],
+            _DELETE_WORKFLOW_STATUSES,
+        )
+        assert result == ["wf-1"]
+
+    @pytest.mark.asyncio
+    async def test_matches_terminal_workflow_from_output_when_load_output_true(self):
+        workflow_status = _build_user_action_workflow_with_output("ua-done", "wf-done")
+        sched, mock_instance = _make_scheduler_with_mock_instance()
+        mock_instance.list_workflows_async = mock.AsyncMock(return_value=[workflow_status])
+        result = await sched._get_user_action_workflow_ids(
+            None,
+            ["ua-done"],
+            _DELETE_WORKFLOW_STATUSES,
+            load_output=True,
+        )
+        assert result == ["wf-done"]
+
+    @pytest.mark.asyncio
+    async def test_get_workflows_to_delete_merges_automation_and_user_action_ids(self):
+        automation_task = octobot_node.models.Task(
+            id=PARENT_ID,
+            name="automation-task",
+            content="encrypted_content",
+            content_metadata="meta",
+            type="execute_actions",
+        )
+        automation_workflow = _build_mock_workflow_status(
+            automation_task,
+            "encrypted_state",
+            None,
+            workflow_id=PARENT_ID,
+        )
+        user_action_workflow = _build_user_action_workflow_with_output("ua-delete", "wf-ua-delete")
+
+        async def list_workflows_side_effect(**kwargs):
+            queue_name = kwargs.get("queue_name")
+            if queue_name == [octobot_node.enums.SchedulerQueues.AUTOMATION_WORKFLOW_QUEUE.value]:
+                return [automation_workflow]
+            if queue_name == [octobot_node.enums.SchedulerQueues.USER_ACTION_QUEUE.value]:
+                return [user_action_workflow]
+            return []
+
+        sched, mock_instance = _make_scheduler_with_mock_instance()
+        mock_instance.list_workflows_async = mock.AsyncMock(side_effect=list_workflows_side_effect)
+        result = await sched._get_workflows_to_delete([PARENT_ID, "ua-delete"])
+        assert result == [PARENT_ID, "wf-ua-delete"]

packages/tentacles/Services/Interfaces/node_api_interface/api/routes/tasks.py

@@ -125,7 +125,7 @@ async def export_results(body: ExportResultsBody, current_user: CurrentUser) ->
 @router.delete("/", response_model=list[str])
 async def delete_tasks(
     current_user: CurrentUser,
-    taskIds: list[uuid.UUID] = Query(...),
+    taskIds: list[str] = Query(...),
 ) -> list[str]:
     requested_ids = [str(t) for t in taskIds]
     if not current_user.is_superuser:

packages/tentacles/Services/Interfaces/node_web_interface/src/components/Common/Tables/TableSelectionCell.tsx

@@ -0,0 +1,28 @@
+import { CenteredCellContent } from "@/components/Common/Tables/CenteredCellContent"
+import { Checkbox } from "@/components/ui/checkbox"
+import { TableCell } from "@/components/ui/table"
+import { debugTableCellClass } from "@/lib/debug/display-utils"
+
+type TableSelectionCellProps = {
+  rowId: string
+  selected: boolean
+  onToggleRow: (id: string) => void
+}
+
+export function TableSelectionCell({
+  rowId,
+  selected,
+  onToggleRow,
+}: TableSelectionCellProps) {
+  return (
+    <TableCell className={debugTableCellClass("center", "w-10")}>
+      <CenteredCellContent>
+        <Checkbox
+          aria-label={`Select row ${rowId}`}
+          checked={selected}
+          onCheckedChange={() => onToggleRow(rowId)}
+        />
+      </CenteredCellContent>
+    </TableCell>
+  )
+}

packages/tentacles/Services/Interfaces/node_web_interface/src/components/Common/Tables/TableSelectionHeader.tsx

@@ -0,0 +1,44 @@
+import { CenteredCellContent } from "@/components/Common/Tables/CenteredCellContent"
+import { Checkbox } from "@/components/ui/checkbox"
+import { TableHead } from "@/components/ui/table"
+
+type TableSelectionHeaderProps = {
+  visibleIds: string[]
+  selectedIds: Set<string>
+  onToggleAllVisible: (ids: string[], select: boolean) => void
+}
+
+export function TableSelectionHeader({
+  visibleIds,
+  selectedIds,
+  onToggleAllVisible,
+}: TableSelectionHeaderProps) {
+  const selectedVisibleCount = visibleIds.filter((id) =>
+    selectedIds.has(id),
+  ).length
+  const allVisibleSelected =
+    visibleIds.length > 0 && selectedVisibleCount === visibleIds.length
+  const someVisibleSelected =
+    selectedVisibleCount > 0 && selectedVisibleCount < visibleIds.length
+
+  return (
+    <TableHead className="w-10 text-center">
+      <CenteredCellContent>
+        <Checkbox
+          aria-label="Select all visible rows"
+          checked={
+            allVisibleSelected
+              ? true
+              : someVisibleSelected
+                ? "indeterminate"
+                : false
+          }
+          disabled={visibleIds.length === 0}
+          onCheckedChange={() => {
+            onToggleAllVisible(visibleIds, !allVisibleSelected)
+          }}
+        />
+      </CenteredCellContent>
+    </TableHead>
+  )
+}

packages/tentacles/Services/Interfaces/node_web_interface/src/components/Debug/DebugExecuteActionDialogHost.tsx

@@ -0,0 +1,57 @@
+import {
+  forwardRef,
+  useCallback,
+  useImperativeHandle,
+  useState,
+} from "react"
+
+import { ExecuteActionDialog } from "@/components/Debug/dialogs/ExecuteActionDialog"
+import type { ExecuteActionDraft } from "@/lib/debug/types"
+
+export type DebugExecuteActionHandle = {
+  open: (draft?: ExecuteActionDraft) => void
+}
+
+type DebugExecuteActionDialogHostProps = {
+  walletAddress?: string
+  onSuccess: () => void
+  copyOnly: boolean
+}
+
+export const DebugExecuteActionDialogHost = forwardRef<
+  DebugExecuteActionHandle,
+  DebugExecuteActionDialogHostProps
+>(function DebugExecuteActionDialogHost(
+  { walletAddress, onSuccess, copyOnly },
+  ref,
+) {
+  const [executeOpen, setExecuteOpen] = useState(false)
+  const [executeDraft, setExecuteDraft] = useState<ExecuteActionDraft | null>(
+    null,
+  )
+
+  const open = useCallback((draft?: ExecuteActionDraft) => {
+    setExecuteDraft(draft ?? null)
+    setExecuteOpen(true)
+  }, [])
+
+  useImperativeHandle(ref, () => ({ open }), [open])
+
+  const handleExecuteOpenChange = (openDialog: boolean) => {
+    setExecuteOpen(openDialog)
+    if (!openDialog) {
+      setExecuteDraft(null)
+    }
+  }
+
+  return (
+    <ExecuteActionDialog
+      open={executeOpen}
+      onOpenChange={handleExecuteOpenChange}
+      walletAddress={walletAddress}
+      onSuccess={onSuccess}
+      draft={executeDraft}
+      copyOnly={copyOnly}
+    />
+  )
+})