fix bydfi

Author: GuillaumeDSM

python/ccxt/async_support/bydfi.py

@@ -1267,6 +1267,8 @@ def create_order_request(self, symbol: str, type: OrderType, side: OrderSide, am
             workingType = 'CONTRACT_PRICE'
             workingType, params = self.handle_option_and_params(params, 'createOrder', 'triggerPriceType', workingType)
             request['workingType'] = self.encode_working_type(workingType)
+        # Never forward unified triggerPrice into Bydfi's REST body(API uses stopPrice); stray keys come from helpers/tests on some runtimes.
+        params = self.omit(params, ['triggerPrice'])
         return self.extend(request, params)
 
     def encode_working_type(self, workingType: Str) -> Str:

python/ccxt/bydfi.py

@@ -1267,6 +1267,8 @@ def create_order_request(self, symbol: str, type: OrderType, side: OrderSide, am
             workingType = 'CONTRACT_PRICE'
             workingType, params = self.handle_option_and_params(params, 'createOrder', 'triggerPriceType', workingType)
             request['workingType'] = self.encode_working_type(workingType)
+        # Never forward unified triggerPrice into Bydfi's REST body(API uses stopPrice); stray keys come from helpers/tests on some runtimes.
+        params = self.omit(params, ['triggerPrice'])
         return self.extend(request, params)
 
     def encode_working_type(self, workingType: Str) -> Str:

ts/src/bydfi.ts

@@ -1309,6 +1309,9 @@ export default class bydfi extends Exchange {
             [ workingType, params ] = this.handleOptionAndParams (params, 'createOrder', 'triggerPriceType', workingType);
             request['workingType'] = this.encodeWorkingType (workingType);
         }
+        // Never forward unified triggerPrice into Bydfi's REST body (API uses stopPrice); stray keys come from helpers/tests on some runtimes.
+        // Omit params.type so a polluted params dict (e.g. Python mutable default {}) cannot override the computed API order type.
+        params = this.omit (params, [ 'triggerPrice', 'type' ]);
         return this.extend (request, params);
     }
 

ts/src/test/static/request/bydfi.json

@@ -35,7 +35,7 @@
                     null,
                     6000
                 ],
-                "output": "{\"quantity\":\"1\",\"side\":\"SELL\",\"stopPrice\":\"6000\",\"symbol\":\"ETH-USDC\",\"triggerPrice\":\"0.18\",\"type\":\"TAKE_PROFIT\",\"wallet\":\"W001\",\"workingType\":\"CONTRACT_PRICE\"}"
+                "output": "{\"quantity\":\"1\",\"side\":\"SELL\",\"stopPrice\":\"6000\",\"symbol\":\"ETH-USDC\",\"type\":\"TAKE_PROFIT_MARKET\",\"wallet\":\"W001\",\"workingType\":\"CONTRACT_PRICE\"}"
             }
         ],
         "createStopLossOrder": [
@@ -51,7 +51,7 @@
                     null,
                     2000
                 ],
-                "output": "{\"quantity\":\"1\",\"side\":\"SELL\",\"stopPrice\":\"2000\",\"symbol\":\"ETH-USDC\",\"triggerPrice\":\"0.01\",\"type\":\"STOP_MARKET\",\"wallet\":\"W001\",\"workingType\":\"CONTRACT_PRICE\"}"
+                "output": "{\"quantity\":\"1\",\"side\":\"SELL\",\"stopPrice\":\"2000\",\"symbol\":\"ETH-USDC\",\"type\":\"STOP_MARKET\",\"wallet\":\"W001\",\"workingType\":\"CONTRACT_PRICE\"}"
             }
         ],
         "createOrder": [