[Lint] Linter fixes

Author: GuillaumeDSM

examples/ts/wizardswap-create-swap.ts

@@ -10,7 +10,7 @@
 // Example:
 //   npx tsx examples/ts/wizardswap-create-swap.ts bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh 0.5
 
-import ccxt from '../../ts/ccxt.js';
+import ccxt from '../../js/ccxt.js';
 
 async function main () {
     const btcAddress = process.argv[2];

examples/ts/wizardswap-estimate-swap.ts

@@ -4,7 +4,7 @@
 // Usage:  npx tsx examples/ts/wizardswap-estimate-swap.ts [BASE/QUOTE] [amount]
 // E.g.:   npx tsx examples/ts/wizardswap-estimate-swap.ts XMR/BTC 1
 
-import ccxt from '../../ts/ccxt.js';
+import ccxt from '../../js/ccxt.js';
 
 async function main () {
     const symbol = process.argv[2] || 'XMR/BTC';

examples/ts/wizardswap-fetch-currencies.ts

@@ -1,7 +1,7 @@
 // WizardSwap — fetch all supported currencies
 // No API key needed
 
-import ccxt from '../../ts/ccxt.js';
+import ccxt from '../../js/ccxt.js';
 
 async function main () {
     const exchange = new ccxt.wizardswap ();

python/ccxt/async_support/ob_binance.py

@@ -10,9 +10,9 @@
 from ccxt.base.errors import ExchangeError
 from ccxt.base.errors import AuthenticationError
 from ccxt.base.errors import PermissionDenied
+from ccxt.base.errors import OBOrderUncancellableError
 from ccxt.base.errors import OrderImmediatelyFillable
 from ccxt.base.errors import NotSupported
-from ccxt.base.errors import OBOrderUncancellableError
 
 
 class ob_binance(binance, ImplicitAPI):
@@ -91,6 +91,16 @@ def describe(self) -> Any:
         })
 
     def create_order_request(self, symbol: str, type: OrderType, side: OrderSide, amount: float, price: Num = None, params={}):
+        """
+ Spot market sells keep base quantity; strip reference price before delegating(OctoBot Binance parity).
+ @param symbol Symbol passed through.
+ @param type Order type passed through.
+ @param side Order side passed through.
+ @param amount Amount passed through.
+ @param price Optional limit/reference price(cleared for spot market sells).
+ @param params Extra parameters passed through.
+        :returns: Result of parent `createOrderRequest`.
+        """
         market = self.market(symbol)
         effectivePrice = price
         if self.safe_bool(market, 'spot', False) and type.upper() == 'MARKET' and side.upper() == 'SELL':
@@ -101,6 +111,8 @@ def create_order_request(self, symbol: str, type: OrderType, side: OrderSide, am
     def uses_demo_trading_instead_of_sandbox(self, exchangeType: Str) -> Bool:
         """
  Binance futures use demo trading instead of classic sandbox(OctoBot binance tentacle); accept `futures` spelling too.
+ @param exchangeType Exchange subtype string from options or caller.
+        :returns: Whether demo-trading semantics apply(`future` / `futures`).
         """
         normalized = str(exchangeType or '').lower()
         return(normalized == 'future') or (normalized == 'futures')

python/ccxt/async_support/ob_coinbase.py

@@ -120,6 +120,13 @@ async def create_order(self, symbol: str, type: OrderType, side: OrderSide, amou
  Coinbase only supports stop-limit orders, not stop-market(`coinbase#createOrder` throws).
  OctoBot `Coinbase._create_market_stop_loss_order`: limit stop-loss with limit = trigger * 0.98
  (STOP_LIMIT_ORDER_INSTANT_FILL_PRICE_RATIO in coinbase_exchange.py).
+ @param symbol Symbol passed through.
+ @param type Order type passed through(market stop-loss is rewritten to limit).
+ @param side Order side passed through.
+ @param amount Amount passed through.
+ @param price Limit price passed through when no stop-loss synthesis applies.
+ @param params Extra parameters(`stopLossPrice` / `stopPrice` trigger handling).
+        :returns: Created order from the underlying Coinbase implementation.
         """
         normalizedType = str(type).upper()
         if normalizedType == 'MARKET':

python/ccxt/async_support/ob_hyperliquid.py

@@ -53,6 +53,8 @@ def ob_bump_hyperliquid_cost_min(self, market: Market) -> Market:
         """
  Bump `limits.cost.min` by 10%(same intent HyperLiquidCCXTAdapter.fix_market_status):
  Hyperliquid may reject orders that are only slightly above the advertised minimum notional.
+ @param market Parsed market structure from CCXT.
+        :returns: Market with adjusted minimum cost limit when applicable.
         """
         marketDict = market
         limits = self.safe_dict(marketDict, 'limits', {})

python/ccxt/async_support/ob_kucoin.py

@@ -9,9 +9,9 @@
 from typing import List
 from ccxt.base.errors import PermissionDenied
 from ccxt.base.errors import OBIPWhitelistError
-from ccxt.base.errors import OperationFailed
 from ccxt.base.errors import OBClosedPositionError
 from ccxt.base.errors import OBOrderUncancellableError
+from ccxt.base.errors import OperationFailed
 
 
 class ob_kucoin(kucoin, ImplicitAPI):
@@ -101,6 +101,8 @@ def ob_apply_kucoin_min_funds_cost_min(self, market: Market) -> Market:
         """
  Raise `limits.cost.min` to at least `info.minFunds` when present(OctoBot Kucoin `get_market_status`).
  (spot only)
+ @param market Parsed spot market structure.
+        :returns: Market with reconciled minimum cost limits.
         """
         marketDict = market
         info = self.safe_dict(marketDict, 'info', {})
@@ -136,7 +138,7 @@ async def fetch_open_orders(self, symbol: Str = None, since: Int = None, limit:
             effectiveLimit = 200
         return await super(ob_kucoin, self).fetch_open_orders(symbol, since, effectiveLimit, params)
 
-    def supports_native_edit_order(self, order_type: Str, symbol: Str) -> Bool:
+    def supports_native_edit_order(self, _order_type: Str, symbol: Str) -> Bool:
         return False
 
     def fetch_stop_order_in_different_request(self, symbol: Str) -> Bool:

python/ccxt/async_support/ob_kucoinfutures.py

@@ -9,9 +9,9 @@
 from typing import List
 from ccxt.base.errors import PermissionDenied
 from ccxt.base.errors import OBIPWhitelistError
-from ccxt.base.errors import OperationFailed
 from ccxt.base.errors import OBClosedPositionError
 from ccxt.base.errors import OBOrderUncancellableError
+from ccxt.base.errors import OperationFailed
 
 
 class ob_kucoinfutures(kucoinfutures, ImplicitAPI):
@@ -107,7 +107,7 @@ async def fetch_open_orders(self, symbol: Str = None, since: Int = None, limit:
             effectiveLimit = 200
         return await super(ob_kucoinfutures, self).fetch_open_orders(symbol, since, effectiveLimit, params)
 
-    def supports_native_edit_order(self, order_type: Str, symbol: Str) -> Bool:
+    def supports_native_edit_order(self, _order_type: Str, symbol: Str) -> Bool:
         return False
 
     def fetch_stop_order_in_different_request(self, symbol: Str) -> Bool:

python/ccxt/async_support/ob_mexc.py

@@ -97,7 +97,8 @@ def sign(self, path, api='public', method='GET', params={}, headers=None, body=N
                 url = self.urls['api'][section][access] + '/api/' + self.version + '/' + path
             urlParams = params
             # ob_mexc local override: begin(diff vs mexc.sign) — spot/broker force signing(see mexc_exchange _force_sign ~80-90)
-            if True or access == 'private':
+            # Same truth value as `true or …` here: we only reach self block when forced signing is enabled.
+            if enableForcedSigningAllRequests or access == 'private':
                 if section == 'broker' and ((method == 'POST') or (method == 'PUT') or (method == 'DELETE')):
                     urlParams = {
                         'timestamp': self.nonce(),
@@ -111,7 +112,7 @@ def sign(self, path, api='public', method='GET', params={}, headers=None, body=N
             if urlParams:
                 paramsEncoded = self.urlencode(urlParams)
                 url += '?' + paramsEncoded
-            if True or access == 'private':
+            if enableForcedSigningAllRequests or access == 'private':
                 self.check_required_credentials()
                 signature = self.hmac(self.encode(paramsEncoded), self.encode(self.secret), hashlib.sha256)
                 url += '&' + 'signature=' + signature
@@ -187,8 +188,11 @@ def parse_order(self, order: dict, market: Market = None) -> Order:
         fee = self.safe_dict(parsed, 'fee')
         if status == 'canceled' and fee is None:
             quoteCcy = self.ob_quote_from_symbol(self.safe_string(parsed, 'symbol', ''))
+            feeCurrency = ''
+            if quoteCcy is not None:
+                feeCurrency = quoteCcy
             parsed['fee'] = {
-                'currency': quoteCcy is not quoteCcy if None else '',
+                'currency': feeCurrency,
                 'cost': 0,
             }
         return parsed

python/ccxt/base/exchange.py

@@ -6597,7 +6597,8 @@ def create_expired_option_market(self, symbol: str):
     def ob_is_strict_finite_number(self, n: Num):
         if n is None:
             return False
-        # Reject NaN and infinities using(n==n) and (n-n)==0; avoid number-type guards here
+        # Reject NaN and infinities using(n==n) and (n-n)==0; transpiler-safe for Python(Number.isFinite is not).
+        # eslint-disable-next-line no-self-compare -- intentional NaN check(NaN != NaN); Infinity − Infinity is NaN in JS
         return(n == n) and ((n - n) == 0)
 
     def ob_coerce_scalar_to_float_strict(self, raw: Any):
@@ -8277,12 +8278,12 @@ def is_uta_enabled(self, params={}):
     def ob_resolve_rights_from_imaginary_cancel_catch(self, e: Any, rights: List[str], authPermissionMatch: Str):
         # octobot specific
         if isinstance(e, AuthenticationError):
-            low = str(e).lower()
+            authenticationErrorLower = str(e).lower()
             if authPermissionMatch == 'pair':
-                if low.find('permission') >= 0 and low.find('denied') >= 0:
+                if authenticationErrorLower.find('permission') >= 0 and authenticationErrorLower.find('denied') >= 0:
                     return rights
             else:
-                if low.find('permission') >= 0 or low.find('denied') >= 0:
+                if authenticationErrorLower.find('permission') >= 0 or authenticationErrorLower.find('denied') >= 0:
                     return rights
             raise e
         if isinstance(e, NetworkError):