Skip to content

Commit f16c7bb

Browse files
committed
chore(settings): remove orphaned api_handler/settings/mod.rs dead handler
The file was never mounted: api_handler/mod.rs declares no `pub mod settings;`, so the compiler never included it, and nothing references api_handler::settings::. It was not even route-shadowed — it was orphaned source carrying a stale snake_case UpdatePhysicsRequest physics handler with no GPU propagation. The live PUT /api/settings/physics is settings_routes.rs::update_physics_settings. Resolves the 2026-04-17 audit master action item #9. Removal cannot affect the binary or compilation since the file was never compiled. Co-Authored-By: jjohare <github@thedreamlab.uk>
1 parent 5277610 commit f16c7bb

2 files changed

Lines changed: 1 addition & 408 deletions

File tree

docs/PRD-018-ontosphere-ontology-rigour.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ Priority reflects value × unblocking. WS-0 and WS-1 are prerequisites for WS-3
232232
**Known follow-up (out of scope for WS-4, not yet wired):** the **Browse** sub-tab's class/property tree (`OntologyBrowser``useOntologyStore``GET /api/ontology/public`) reads 0 because `/api/ontology/public` is **404** — no such backend route exists (the live `/api/ontology` scope exposes `/axioms`, `/inferences`, `/hierarchy`, `/report`, …). Repoint the browser to `/hierarchy` (or add a `/classes` endpoint) to populate the tree. The exploration controls, inferred-edge toggle, and the other four sub-tabs (Reason/Forces/Query/Manage) are live.
233233

234234
**Settings control-panel alignment (browser + endpoint-verified 2026-06-05, commit `7c8367e6d`):** re-tested the whole physics settings surface against the live GPU force system and refactored the Physics tab (`unifiedSettingsConfig.ts`) to match.
235-
- **Live path proven empirically.** Physics writes flow slider → `autoSaveManager` (500 ms debounce) → `updatePhysics``PUT /api/settings/physics``settings_routes.rs::update_physics_settings` (key-normalise → `validate_physics_settings` against `physics_bounds``UpdateSimulationParams` to GPUCompute/GPUManager + GraphServiceSupervisor → `ForceResumePhysics`). Direct endpoint test: `repelK` 120→500 expanded graph spread (σ 34.8,36.0,26.7)→(37.7,38.6,28.1), confirming the path reaches the GPU. (The `api_handler/settings/mod.rs::update_physics_settings` variant with snake-case `UpdatePhysicsRequest` and no GPU propagation is **dead**shadowed by the `/api/settings` scope registered first in `main.rs`.)
235+
- **Live path proven empirically.** Physics writes flow slider → `autoSaveManager` (500 ms debounce) → `updatePhysics``PUT /api/settings/physics``settings_routes.rs::update_physics_settings` (key-normalise → `validate_physics_settings` against `physics_bounds``UpdateSimulationParams` to GPUCompute/GPUManager + GraphServiceSupervisor → `ForceResumePhysics`). Direct endpoint test: `repelK` 120→500 expanded graph spread (σ 34.8,36.0,26.7)→(37.7,38.6,28.1), confirming the path reaches the GPU. (The `api_handler/settings/mod.rs::update_physics_settings` variant with snake-case `UpdatePhysicsRequest` and no GPU propagation was **orphaned dead code**never mounted (`api_handler/mod.rs` declares no `pub mod settings;`, so the compiler never included it) and unreferenced anywhere. Removed 2026-06-05, resolving the 2026-04-17 audit master action item #9.)
236236
- **Stale default annotations corrected** to the canonical values in `client/src/api/settings/defaults.ts` (all UI descriptions previously cited pre-retune numbers): springK 15→12, repelK 1200→120, restLength 80→50, centerGravityK 0.05→0.2, gravity 0.0001→0.002, maxForce 1000→150, globalSpeed 0.5→0.4, damping 0.85→0.9, graphSeparationX 250→0, temperature 1.0→0.
237237
- **Slider ranges bound to `physics_bounds`** so the UI can no longer request values the validator 400-rejects: repelK max 3000→500, temperature max 5→1.
238238
- **Duplicated ontology-force controls removed** from the Physics tab (`qualityGates.ontologyPhysics` toggle + `ontologyStrength` slider, which carried a divergent 0.5 default vs the panel's 0.6). The dedicated **Ontology → Forces panel** (`OntologyForcesPanel`) is now the single source of truth for ontology-force enable + global strength; the Physics tab's "Semantic & Layout Forces" group retains only the DAG/type-clustering controls.

0 commit comments

Comments
 (0)