Merge pull request #20 from joeldodge79/drip-client-error-response

Test that a 400 or 500 response is not a success

Author: will-in-wi

src/Client.php

@@ -337,6 +337,7 @@ protected function make_request($url, $params = array(), $req_method = self::GET
                 'Accept' => 'application/json, text/javascript, */*; q=0.01',
                 'Content-Type' => 'application/vnd.api+json',
             ],
+            'http_errors' => false,
         ];
 
         switch ($req_method) {

tests/ClientTest.php

@@ -29,6 +29,22 @@ public function testInvalidAccountId()
         new \Drip\Client("abc123", "");
     }
 
+    public function testErrorResponseReturned()
+    {
+        $mocked_requests = [];
+        $client = GuzzleHelpers::mocked_client($mocked_requests, [
+            // default client request option "http_errors" will throw
+            // GuzzleHttp\Exception\ClientException but we set it false so
+            // no exception is thrown.
+            new Response(401, [], '{"error":"hello"}'),
+            new Response(502, [], 'timeout'),
+        ]);
+        $response401 = $client->fetch_campaign(['campaign_id' => 1]);
+        $this->assertFalse($response401->is_success());
+        $response502 = $client->fetch_campaign(['campaign_id' => 1]);
+        $this->assertFalse($response502->is_success());
+    }
+
     ////////////////////////// C A M P A I G N S //////////////////////////
 
     // #get_campaigns