Refactor DriverqueryCommand for better process handling

Refactor DriverqueryCommand to use ProcessBuilder for command execution and add error handling with a dedicated thread for error stream.

Author: anshumanjadiya1102

src/main/java/com/mycmd/commands/DriverqueryCommand.java

@@ -5,6 +5,10 @@
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
 
 /**
  * Displays a list of all installed device drivers.
@@ -23,22 +27,66 @@ public void execute(String[] args, ShellContext context) throws IOException {
     }
 
     try {
-      StringBuilder cmdBuilder = new StringBuilder("driverquery");
-      for (String arg : args) {
-        cmdBuilder.append(" ").append(arg);
+
+      List<String> command = new ArrayList<>();
+      command.add("cmd.exe");
+      command.add("/c");
+      command.add("driverquery");
+      if (args != null && args.length > 0) {
+        command.addAll(Arrays.asList(args));
+      }
+
+      ProcessBuilder pb = new ProcessBuilder(command);
+      Process process = pb.start();
+
+      Thread errorGobbler =
+          new Thread(
+              () -> {
+                try (BufferedReader errReader =
+                    new BufferedReader(new InputStreamReader(process.getErrorStream()))) {
+                  String errLine;
+                  while ((errLine = errReader.readLine()) != null) {
+                    System.err.println(errLine);
+                  }
+                } catch (IOException e) {
+                  System.err.println("Error reading process error stream: " + e.getMessage());
+                }
+              },
+              "driverquery-error-gobbler");
+      errorGobbler.setDaemon(true);
+      errorGobbler.start();
+
+      try (BufferedReader reader =
+          new BufferedReader(new InputStreamReader(process.getInputStream()))) {
+        String line;
+        while ((line = reader.readLine()) != null) {
+          System.out.println(line);
+        }
       }
 
-      Process process = Runtime.getRuntime().exec(cmdBuilder.toString());
-      BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()));
+      boolean finished;
+      try {
+        finished = process.waitFor(30, TimeUnit.SECONDS);
+      } catch (InterruptedException ie) {
+        Thread.currentThread().interrupt();
+        process.destroyForcibly();
+        throw new IOException("Interrupted while waiting for driverquery process", ie);
+      }
 
-      String line;
-      while ((line = reader.readLine()) != null) {
-        System.out.println(line);
+      if (!finished) {
+        process.destroyForcibly();
+        System.out.println("Command timed out.");
+      } else {
+        int exitCode = process.exitValue();
+        if (exitCode != 0) {
+          System.out.println("Command exited with code: " + exitCode);
+        }
       }
 
-      int exitCode = process.waitFor();
-      if (exitCode != 0) {
-        System.out.println("Command exited with code: " + exitCode);
+      try {
+        errorGobbler.join(1000);
+      } catch (InterruptedException ie) {
+        Thread.currentThread().interrupt();
       }
 
     } catch (Exception e) {