Skip to content

Commit 19567d2

Browse files
authored
feat: capture any warnings as part of the advisories (#46)
This will make it easier to determine when an advisory needs improving, and to confirm when a "patch" has successfully addressed a warning, without bloating all our advisories since the majority of them will be warning free. Note that I've already got fixes for the advisories with warnings in this patch, I just want to have the warnings captured in a "before" commit so that my follow-up patch will be ~more impressive~ show the warnings are correctly addressed.
1 parent b125bea commit 19567d2

12 files changed

Lines changed: 51 additions & 13 deletions

advisories/acquia_dam/osv-sa-contrib-2024-025.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,10 @@
4242
}
4343
],
4444
"database_specific": {
45-
"constraint": ">=1.1.0 <1.1.0-beta3"
45+
"constraint": ">=1.1.0 <1.1.0-beta3",
46+
"warnings": [
47+
"stability does not make sense, using -dev instead"
48+
]
4649
}
4750
}
4851
],

advisories/ai/osv-sa-contrib-2025-003.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@
2828
}
2929
],
3030
"database_specific": {
31-
"constraint": ">1.0.0 <1.0.2"
31+
"constraint": ">1.0.0 <1.0.2",
32+
"warnings": [
33+
"the > operator should be avoided as it does not provide a concrete version"
34+
]
3235
}
3336
}
3437
],

advisories/core/osv-sa-core-2022-002.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
}
2727
],
2828
"database_specific": {
29-
"constraint": ">7.0 <=7.86"
29+
"constraint": ">7.0 <=7.86",
30+
"warnings": [
31+
"the > operator should be avoided as it does not provide a concrete version"
32+
]
3033
}
3134
}
3235
],

advisories/diff/osv-sa-contrib-2024-042.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,10 @@
4242
}
4343
],
4444
"database_specific": {
45-
"constraint": ">=2.0.0 <2.0.0-beta3"
45+
"constraint": ">=2.0.0 <2.0.0-beta3",
46+
"warnings": [
47+
"stability does not make sense, using -dev instead"
48+
]
4649
}
4750
}
4851
],

advisories/jsonapi/osv-sa-contrib-2019-019.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@
3737
}
3838
],
3939
"database_specific": {
40-
"constraint": ">=2.0.0 >2.3.0"
40+
"constraint": ">=2.0.0 >2.3.0",
41+
"warnings": [
42+
"the > operator should not be used for the second part"
43+
]
4144
}
4245
}
4346
],

advisories/protected_pages/osv-sa-contrib-2023-013.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
}
2727
],
2828
"database_specific": {
29-
"constraint": "<1.06"
29+
"constraint": "<1.06",
30+
"warnings": [
31+
"components should not be prefixed with leading zeros"
32+
]
3033
}
3134
}
3235
],

advisories/social/osv-sa-contrib-2024-004.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@
2828
}
2929
],
3030
"database_specific": {
31-
"constraint": "<12.05"
31+
"constraint": "<12.05",
32+
"warnings": [
33+
"components should not be prefixed with leading zeros"
34+
]
3235
}
3336
}
3437
],

advisories/social/osv-sa-contrib-2024-038.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,10 @@
5656
}
5757
],
5858
"database_specific": {
59-
"constraint": ">=13.0.0 <13.0.0-alpha11"
59+
"constraint": ">=13.0.0 <13.0.0-alpha11",
60+
"warnings": [
61+
"stability does not make sense, using -dev instead"
62+
]
6063
}
6164
}
6265
],

advisories/svg_formatter/osv-sa-contrib-2022-028.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@
4040
}
4141
],
4242
"database_specific": {
43-
"constraint": "=2.0.0"
43+
"constraint": "=2.0.0",
44+
"warnings": [
45+
"the = operator is not real, and will be treated as an exact version"
46+
]
4447
}
4548
}
4649
],

advisories/symfony_mailer/osv-sa-contrib-2023-031.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@
4040
}
4141
],
4242
"database_specific": {
43-
"constraint": ">=1.3.0 <1.3.0-rc3"
43+
"constraint": ">=1.3.0 <1.3.0-rc3",
44+
"warnings": [
45+
"stability does not make sense, using -dev instead"
46+
]
4447
}
4548
}
4649
],

0 commit comments

Comments
 (0)