feat: mention advisories that have warnings as part of validation#105
Merged
Conversation
G-Rath
force-pushed
the
validate/print-warnings
branch
5 times, most recently
from
8da669e to
28277d6
Compare
G-Rath
force-pushed
the
validate/print-warnings
branch
from
28277d6 to
47915c1
Compare
G-Rath
requested review from
Unifex,
jonholdsworth,
justineleonard,
nzlaura and
simonchisnall-online
jonholdsworth
approved these changes
Jul 9, 2025
nzlaura
approved these changes
Jul 10, 2025
Unifex
approved these changes
Jul 16, 2025
Unifex
left a comment
Unifex
left a comment
Collaborator
There was a problem hiding this comment.
Ah! This isn't what I was meaning when highlighting skipping/patching/etc. I was meaning highlighting extra info in the generate_osv_advisories.py script. This would give an easy visual reference to the SA URLs that have the issues.
This works though too and I've added the script to my local checks.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help make warnings in advisories stand-out especially for pull requests that add new advisories where the whole diff is just green - this makes use of GitHub Actions annotations (triggered by a log format) to add a visual element to each advisory:
For now it appears at the top of the file since it would be more work to try and determine the line number of the
warningsproperties, and I'm not sure it's worth doing that when ideally in the long-run we want to be working with the upstream to avoid warnings in the first place, but it's something we could explore later if desired or someone was bored 😄