feat: capture any warnings as part of the advisories#46
Merged
Conversation
Collaborator
Author
|
Initially I implemented a cute little custom |
jonholdsworth
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it easier to determine when an advisory needs improving, and to confirm when a "patch" has successfully addressed a warning, without bloating all our advisories since the majority of them will be warning free.
Note that I've already got fixes for the advisories with warnings in this patch, I just want to have the warnings captured in a "before" commit so that my follow-up patch will be
more impressiveshow the warnings are correctly addressed.