Skip to content

fix: mention status code before node ids in exception message#88

Merged
G-Rath merged 1 commit into
mainfrom
adjust-message
Jun 24, 2025
Merged

fix: mention status code before node ids in exception message#88
G-Rath merged 1 commit into
mainfrom
adjust-message

Conversation

@G-Rath

@G-Rath G-Rath commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

This should make it a bit easier to read since nids is an array of up to 50 numbers so currently we get messages like:

Exception: unexpected response when fetching nodes ['1301730', '2999525', '2980066', '3263534', '3415185', '73594', '258223', '2942788', '3046066', '3145765', '1699634', '2425017', '2345891', '1762004', '2956120', '2649868', '1404150', '61442', '2684717', '632214', '225194', '1934188', '1883798', '607826', '173525', '436148', '2348769', '1408882', '20492', '925500', '147151', '2906646', '2579037', '259843', '1087226', '1302522', '2365459', '3066563', '3245777', '2788489', '3152933', '2705191', '169791', '1509408', '2846636', '19304', '3261896', '2887155', '3228985', '1909836']: 429

Whereas now we'll get:

Exception: unexpected 429 response when fetching nodes ['1301730', '2999525', '2980066', '3263534', '3415185', '73594', '258223', '2942788', '3046066', '3145765', '1699634', '2425017', '2345891', '1762004', '2956120', '2649868', '1404150', '61442', '2684717', '632214', '225194', '1934188', '1883798', '607826', '173525', '436148', '2348769', '1408882', '20492', '925500', '147151', '2906646', '2579037', '259843', '1087226', '1302522', '2365459', '3066563', '3245777', '2788489', '3152933', '2705191', '169791', '1509408', '2846636', '19304', '3261896', '2887155', '3228985', '1909836']

@nzlaura nzlaura left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: that is a lot easier to read 🎉

@G-Rath G-Rath merged commit 7728d37 into main Jun 24, 2025
8 checks passed
@G-Rath G-Rath deleted the adjust-message branch June 24, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants