feat: retry request if api returns a 429 when precaching nodes#90
Merged
Conversation
G-Rath
force-pushed
the
support-retrying
branch
2 times, most recently
from
3c3a956 to
7ed7d7a
Compare
jonholdsworth
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a couple of our (re)generation runs fail when precaching the Drupal nodes due to 429s - we might as well include a basic "retry once" attempt to help avoid this. While it's possible this could happen for any API request it should be very unlikely except for this one which is why I've not changed them.
In the long-run if this becomes more regular (or requested by the Drupal team) we'll probably move to a more dedicated HTTP client implementation to handle this across the board