Commit cb9fba5
committed
fix(dstack-ingress): stop the placeholder path reporting itself as a failure
On a first tls-alpn-01 run the log read:
Generating placeholder certificate for app.example.com
Warning: Cert files missing for app.example.com, skipping
The warning is what build_combined_pems prints whenever lego has no
certificate yet, which on the first pass is exactly the situation the
placeholder exists to cover. Nothing is wrong -- skipping is what keeps
the placeholder in place so haproxy can bind and forward acme-tls/1 --
but back to back with the line above it reads like the placeholder was
discarded, and it is the first thing a new deployment shows.
Distinguish the two cases: keeping a placeholder is normal, having
neither a certificate nor a placeholder is not. dns-01 has no
placeholder, so its copy keeps the original wording.1 parent ed3ca43 commit cb9fba5
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
164 | 169 | | |
165 | | - | |
| 170 | + | |
166 | 171 | | |
167 | 172 | | |
168 | 173 | | |
| |||
0 commit comments